Update infobox styling #406
Conversation
There was a problem hiding this comment.
I'm not sure using a taxonomy for info box variant is the best way to go.
When using a taxonomy, the editor must make sure that the taxonomy term names match the defined info box css styles to make it work, i.e. they must know something about what goes on behind the scenes. Furthermore, using a taxonomy may make the editor think that they can just invent new info box variants by creating a new taxonomy term, and while this is technically true, it will not work in practice because there is no styling to match the new variant.
Using a simple select element on the info box paragraph may be a better solution. This will let the designer control which info box variants are available and create the matching styling if new ones are needed.
|
Thank you @rimi-itk - That makes sense. I will have a look at using a |
| @@ -41,7 +41,7 @@ | |||
| <div class="container"> | |||
| <div class="row"> | |||
| <div class="col-md-8"> | |||
| <div class="info-box rounded overflow-hidden {{ elements.field_variant.0['#plain_text']|clean_class }}"> | |||
| <div class="info-box rounded overflow-hidden {{ elements.field_variant_select.0['#markup']|clean_class }}"> | |||
There was a problem hiding this comment.
Can value be used here, i.e.
| <div class="info-box rounded overflow-hidden {{ elements.field_variant_select.0['#markup']|clean_class }}"> | |
| <div class="info-box rounded overflow-hidden {{ elements.field_variant_select.value|clean_class }}"> |
?
There was a problem hiding this comment.
Would love to use value since it is cleaner. But unfortunately, it only returns null.
| @@ -5,7 +5,7 @@ dependencies: | |||
| config: | |||
| - field.field.paragraph.info_box.field_content_block_text | |||
| - field.field.paragraph.info_box.field_paragraph_title | |||
| - field.field.paragraph.info_box.field_variant | |||
| - field.field.paragraph.info_box.field_variant_select | |||
There was a problem hiding this comment.
It may be worth not including _select in the field machine name. It's not important (to not include it), but we usually don't embed the field type in the name.
Renaming the machine name can be done with search and replace in the config files and by renaming files with field_variant_select in the name.
There was a problem hiding this comment.
Absolutely - Changed with latest commit.
https://leantime.itkdev.dk/dashboard/home?tab=ticketdetails#/tickets/showTicket/1340