Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 #428

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

PHP 8.4 #428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
extensions: ctype, dom, iconv, json, zip, gd, soap
coverage: none
tools: composer:v2
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
extensions: ctype, dom, iconv, json, zip, gd, soap
coverage: none
tools: composer:v2
Expand Down Expand Up @@ -97,7 +97,7 @@ jobs:
- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
extensions: ctype, dom, iconv, json, zip, gd, soap
coverage: none
tools: composer:v2
Expand Down Expand Up @@ -143,7 +143,7 @@ jobs:
- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: 8.3
php-version: 8.4
extensions: ctype, dom, iconv, json, zip, gd, soap
coverage: none
tools: composer:v2
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

* [PR-428](https://github.com/itk-dev/hoeringsportal/pull/428)
PHP 8.4
* [PR-427](https://github.com/itk-dev/hoeringsportal/pull/427)
Updated docker compose setup. Updated composer packages.
* [PR-425](https://github.com/itk-dev/hoeringsportal/pull/425)
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.server.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ networks:

services:
phpfpm:
image: itkdev/php8.3-fpm:alpine
image: itkdev/php8.4-fpm:alpine
restart: unless-stopped
networks:
- app
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ services:
com.symfony.server.service-prefix: 'DATABASE'

phpfpm:
image: itkdev/php8.3-fpm:latest
image: itkdev/php8.4-fpm:latest
networks:
- app
extra_hosts:
Expand Down
2 changes: 1 addition & 1 deletion web/modules/custom/hoeringsportal_data/src/Helper/GeoJsonHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ private function getReference($entity, $field_name) {
/**
* Get term name.
*/
private function getTermName(Term $term = NULL) {
private function getTermName(?Term $term = NULL) {
return $term ? $term->get('name')->value : NULL;
}

Expand Down
Loading