KUNST-77: Security updates #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimi-itk
force-pushed
the
feature/KUNST-77-security-update
branch
from
cf00ab3 to
6d23319
Compare
rimi-itk
force-pushed
the
feature/KUNST-77-security-update
branch
from
6d23319 to
e53bc13
Compare
rimi-itk
changed the title
tuj
approved these changes
Dec 8, 2023
rimi-itk
force-pushed
the
feature/KUNST-77-security-update
branch
from
0f6d7e1 to
c56e352
Compare
tuj
requested changes
Dec 11, 2023
src/Entity/Item.php
Outdated
| #[ORM\OneToMany(targetEntity: Image::class, mappedBy: 'item', cascade: ['persist'])] | ||
| private $images; | ||
| private ArrayCollection|PersistentCollection|iterable $images; |
There was a problem hiding this comment.
This look weird. Shouldn't it just be Collection?
There was a problem hiding this comment.
Yes, it should. Fixed in 66fe6e0.
tuj
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.itkdev.dk/browse/KUNST-77
Security updates and clean-ups.