Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#42] Add base URL to AJAX URL call #59

Merged
merged 2 commits into from
Mar 27, 2023
Merged

[#42] Add base URL to AJAX URL call #59

merged 2 commits into from
Mar 27, 2023

Conversation

skillmatic-co
Copy link
Contributor

Adding in a base_url setting would be a solution to #42

Adding in a base_url setting would be a solution to #42
Copy link
Owner

@itmammoth itmammoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!
Can you change base_url to camel case?

@skillmatic-co
Copy link
Contributor Author

Done. Sorry, I've been in Ruby mode.

@skillmatic-co skillmatic-co requested a review from itmammoth March 27, 2023 02:58
Copy link
Owner

@itmammoth itmammoth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itmammoth itmammoth merged commit de941f5 into itmammoth:master Mar 27, 2023
@skillmatic-co
Copy link
Contributor Author

Thanks! This solved my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants