Trac 1.2 #45
Open
Trac 1.2 #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added auxiliary stored functions for reporting
Fixes for several tickets pre transfer to track-hacks
rjollos
reviewed
Dec 14, 2016
| @@ -50,7 +50,6 @@ | |||
| """, | |||
| license = 'BSD', | |||
|
|
|||
| install_requires = ['Trac >= 0.12dev'], | |||
There was a problem hiding this comment.
You may be interested in: https://trac-hacks.org/wiki/DevGuide#AssertMinimumTracVersionRequirement
rjollos
reviewed
Dec 14, 2016
| description = 'Trac Sub-Tickets Plugin', | ||
| long_description = """ | ||
| This plugin for Trac 0.12 provides Sub-Tickets functionality. | ||
| This plugin for Trac 0.12 and later provides Sub-Tickets functionality. |
There was a problem hiding this comment.
By using transaction context managers, the plugin will not longer be compatible with Trac < 1.0.
I've been dropping support for Trac < 1.0 on plugins I develop. It's not worth the effort to support any longer, is my opinion.
rjollos
reviewed
Dec 14, 2016
| else: | ||
| cursor.execute("UPDATE system SET value=%s WHERE name=%s", | ||
| (db_default.version, db_default.name)) | ||
| with self.env.db_transaction as db: |
There was a problem hiding this comment.
One other thing about Trac versions. Officially Trac 1.0 still supports Python 2.5. That's a rather old Python version, but if you do care about it, you'll need to add from __future__ import with_statement to the top of any files in which a transaction context manager is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For second round of review.