🌈 move constants and library out #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mentalko
force-pushed
the
14.0-importing_out
branch
from
d56da0c
to
535a693
Compare
yelizariev
reviewed
Jul 16, 2021
|
fetch + rebase |
mentalko
force-pushed
the
14.0-importing_out
branch
7 times, most recently
from
f3fd1b2
to
c48526a
Compare
yelizariev
reviewed
Jul 19, 2021
sync_telegram/models/sync_project.py
Outdated
| @@ -7,13 +7,20 @@ | |||
| import logging | |||
|
|
|||
| import requests | |||
| from lxml.html.clean import Cleaner | |||
| from telegram import Bot, Update # pylint: disable=missing-manifest-dependency | |||
There was a problem hiding this comment.
Add comment to the code why it's disabled
mentalko
force-pushed
the
14.0-importing_out
branch
from
c48526a
to
38e346a
Compare
it was copy-pasted from sync module, where telegram is a demo and we don't require to installing telegram package close itpp-labs#294
mentalko
force-pushed
the
14.0-importing_out
branch
from
38e346a
to
eaed8c0
Compare
yelizariev
approved these changes
Jul 23, 2021
trojikman
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
может move неуместно здесь и стоит заменить на что-то другое?