Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "updated the FAB menu actions" #3

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Revert "updated the FAB menu actions" #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions workspaces/global-floating-action-button/packages/app/src/components/Root/Root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ export const Root = ({ children }: PropsWithChildren<{}>) => {
},
{
slot: Slot.BOTTOM_LEFT,
icon: <ExtensionIcon />,
label: 'Apis',
toolTip: 'Apis',
icon: <LibraryBooks />,
label: 'Api Docs',
toolTip: 'Api Docs',
to: '/api-docs',
},
{
slot: Slot.BOTTOM_LEFT,
icon: <LibraryBooks />,
icon: <ExtensionIcon />,
showLabel: true,
label: 'Docs',
toolTip: 'Docs',
Expand All @@ -118,13 +118,22 @@ export const Root = ({ children }: PropsWithChildren<{}>) => {
onClick: toggleModal,
},
{
color: 'success',
icon: <GitHubIcon />,
label: 'RHDH plugins',
label: 'RHDH pluginsssssssssssssss',
showLabel: true,
toolTip: 'RHDH plugins',
to: 'https://github.com/redhat-developer/rhdh-plugins',
visibleOnPaths: ['/catalog'],
},
{
color: 'success',
icon: <GitHubIcon />,
label: 'RHDH pluginsssssssssssssss',
toolTip: 'External link',
to: 'https://github.com/redhat-developer/rhdh-plugins',
visibleOnPaths: ['/catalog'],
},
{
color: 'success',
icon: <UserSettingsSignInAvatar />,
Expand Down
6 changes: 3 additions & 3 deletions ...lobal-floating-action-button/plugins/global-floating-action-button/src/components/FAB.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const FABLabel = ({
const styles = useStyles();
const marginStyle = slotOptions[slot].margin;
return (
<>
<Typography sx={{ display: 'flex' }}>
{showExternalIcon && (
<OpenInNewIcon
className={styles.openInNew}
Expand All @@ -68,11 +68,11 @@ const FABLabel = ({
</Typography>
)}
{icon && (
<Typography sx={{ order: order.icon }}>
<Typography sx={{ mb: -1, order: order.icon }}>
<FabIcon icon={icon} />
</Typography>
)}
</>
</Typography>
);
};

Expand Down