refactor(ui): switch css to scss #65
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
=====================================
Coverage 2.76% 2.76%
=====================================
Files 44 44
Lines 2786 2786
Branches 57 57
=====================================
Hits 77 77
Misses 2666 2666
Partials 43 43 ☔ View full report in Codecov by Sentry. |
| }, | ||
| "pnpm": { | ||
| "overrides": { | ||
| "esbuild": "0.19.2" |
There was a problem hiding this comment.
why do we need this override here?
There was a problem hiding this comment.
We need to overwrite tsup esbuild version v0.18, since the sass plugin using v0.19 where the Plugin type definition changes. This can be removed after tsup updates to esbuild v0.19.
| /// @param {Map} $map - The map. | ||
| /// @param {Arglist} $keys - The key chain. | ||
| /// @return {*} - The desired value. | ||
| @function map-deep-get($map, $keys...) { |
There was a problem hiding this comment.
why do we need all this setup and utility code? it's more than 1000 lines of code just to add scss support and I am worried about the maintainability, because it adds complexity to the codebase
There was a problem hiding this comment.
Don't worry and please wait till you see the advantages for storylite users and us when using these few utility classes.
itsjavi
added
the
improvement
Description
Main purpose is to refactor code by replacing
CSSwith modern modular approachSCSS.Will result in:
DOM Nodesfor faster renderingRoadmap
WIP Draft
I will use parts of the code of my wip scss library.