Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to display title on Documentcloud.org embeds #562

Merged
merged 11 commits into from
Nov 6, 2024
Merged

Option to display title on Documentcloud.org embeds #562

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12537e0
Display title on Documentcloud.org embeds
garmoncheg Nov 1, 2024
743632d
Option title to allowTitle as it is boolean, use og instead of oembed
garmoncheg Nov 1, 2024
2b40fed
documentcloud.org title param move back to previous naming and defaul…
garmoncheg Nov 4, 2024
51043f1
cleanup
garmoncheg Nov 4, 2024
498241a
Use both `og` and `oembed` title
garmoncheg Nov 4, 2024
ad618ba
Revert "Use both `og` and `oembed` title"
garmoncheg Nov 4, 2024
a20c1b0
Reapply "Use both `og` and `oembed` title"
garmoncheg Nov 4, 2024
c9040b2
propagate title param to iframe src
garmoncheg Nov 5, 2024
6ed9647
Append param only if title is true.
garmoncheg Nov 6, 2024
1eea7e7
use internal util and add test url with title param
garmoncheg Nov 6, 2024
2e1cc64
Remove unused test
garmoncheg Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions plugins/domains/documentcloud.org.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ export default {
"author",
"og-title",
"og-image",
"og-description"
"og-description",
"oembed-title"
],

// plugin is required to add aspect-ratio and with this fix embeds when used inside iFrame
Expand All @@ -31,10 +32,11 @@ export default {

if (!/DC\-note/.test(html) && !/DC\-embed(?:\-page)?/.test(html)) {
var page = options.getRequestOptions('documentcloud.page', '1');
var title = !!options.getRequestOptions('documentcloud.title', false);

try {
var iframe = oembed.getIframe();
var href = iframe.src;
var href = title ? iframe.replaceQuerystring({ title: 1 }) : iframe.src;

if (page && page !== '1') {
if (href) {
Expand All @@ -51,6 +53,10 @@ export default {
page: {
label: CONFIG.L.page,
value: parseInt (page)
},
title: {
label: 'Show title',
value: title
}
}
} catch (ex) {}
Expand Down Expand Up @@ -95,7 +101,8 @@ export default {
'author',
'canonical',
'og-title',
'og-image'
'og-image',
'oembed-title'
]},
'https://www.documentcloud.org/documents/73991-day-three-documents',
'https://www.documentcloud.org/documents/5766398-ASRS-Reports-for-737-max8.html#document/p2/a486265',
Expand Down