Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included user agent for download #459

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Included user agent for download #459

merged 2 commits into from
Sep 23, 2024

Conversation

jacokok
Copy link
Contributor

@jacokok jacokok commented Sep 23, 2024

Added user agent to curl download
-A "itzg/minecraft-bedrock-server"

Not sure if curlArgs could have been used but this seems to resolve the issue for now.

Fixes #358

@mrgrosser
Copy link

Approved

Copy link
Owner

@itzg itzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I hadn't realized this whole time that I only had the agent specified on the version lookup call further up.

@itzg
Copy link
Owner

itzg commented Sep 23, 2024

Not sure if curlArgs could have been used but this seems to resolve the issue for now.

Yeah adding to curlArgs would have been better, but that can be done in a follow up PR so you can make progress for now.

@itzg itzg merged commit a5b46e5 into itzg:master Sep 23, 2024
1 check passed
@sbogomolov
Copy link

@jacokok Thanks for fixing this.
@itzg Any chance we can get a release with this change? :)

@itzg
Copy link
Owner

itzg commented Sep 27, 2024

@jacokok Thanks for fixing this.

@itzg Any chance we can get a release with this change? :)

Its already pushed, but if you mean a tagged release then I'll kick that off too 😀

@itzg
Copy link
Owner

itzg commented Sep 27, 2024

@sbogomolov
Copy link

Tagged version is pushed https://github.com/itzg/docker-minecraft-bedrock-server/releases/tag/2024.9.0

Thank you!

@Hossy
Copy link

Hossy commented Oct 1, 2024

Thank you!!

@c-gunther
Copy link

Tagged version is pushed https://github.com/itzg/docker-minecraft-bedrock-server/releases/tag/2024.9.0

Could you please tag 2024.0.9 as latest as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error downloading minecraft server zip, curl fails
6 participants