Fix: eliminated hardcoded URL for custom versions #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old behavior: Custom versions used hardcoded download URL. this URL should be dynamically sourced using the lookupVersion command instead. New behavior: lookupVersion takes a second parameter, version, and uses a simple sed replace to insert the version parameter into the download URL dynamically, if it was successfully found. Also, removed old bedrock version shortcuts. This can be restored and modified to use the lookupVersion command to get the right URL if needed. It's unclear whether there's any active servers still running on legacy versions of bedrock (to this author). Resolves itzg#460
itzg
reviewed
Oct 8, 2024
thedhruvn
commented
Oct 8, 2024
I don't love hard-coded URLs in general - my suggestion would be to adopt this so we follow the once and only once principle in managing constants. |
|
That's fair. Let's see how the preview support looks. |
Old behavior: custom version only supported versioning for non-preview releases. New behavior: custom version can look up custom preview versions and custom release versions based on the value of the PREVIEW flag.
itzg
reviewed
Oct 17, 2024
itzg
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
These all worked correctly:
docker run -it --rm -e EULA=true -e VERSION=PREVIEW itzg/minecraft-bedrock-server
docker run -it --rm -e EULA=true -e VERSION=1.21.50.24 -e PREVIEW=true itzg/minecraft-bedrock-server
docker run -it --rm -e EULA=true -e VERSION=LATEST itzg/minecraft-bedrock-server
docker run -it --rm -e EULA=true -e VERSION=1.21.31.04 itzg/minecraft-bedrock-server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old behavior: Custom versions used hardcoded download URL. this URL should be dynamically sourced using the lookupVersion command instead.
New behavior: lookupVersion takes a second parameter, version, and uses a simple sed replace to insert the version parameter into the download URL dynamically, if it was successfully found.
Also, removed old bedrock version shortcuts. This can be restored and modified to use the lookupVersion command to get the right URL if needed. It's unclear whether there's any active servers still running on legacy versions of bedrock (to this author).
Resolves #460