Skip to content

paper: pick max build and not assume first is newest #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2025
Merged

paper: pick max build and not assume first is newest #658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/java/me/itzg/helpers/paper/PaperDownloadsClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,20 @@ private Mono<VersionBuild> extractLatestVersionBuild(String project, RequestedCh
return Flux.fromIterable(projectResponse.getVersions())
.filter(versionResponse -> versionResponse.getBuilds() != null && !versionResponse.getBuilds().isEmpty())
.concatMap(versionResponse ->
getBuild(project, versionResponse.getVersion().getId(), versionResponse.getBuilds().get(0))
getBuild(project, versionResponse.getVersion().getId(), getLatestBuild(versionResponse))
.map(buildResponse -> new VersionAndBuildResponse(versionResponse, buildResponse))
)
.takeUntil(vAndB -> acceptableChannel(vAndB.buildResponse.getChannel(), requestedChannel))
.last()
.map(vAndB -> new VersionBuild(vAndB.versionResponse.getVersion().getId(), vAndB.buildResponse.getId()));
}

private static Integer getLatestBuild(VersionResponse versionResponse) {
return versionResponse.getBuilds().stream()
.max(Integer::compare)
.orElseThrow(() -> new GenericException("No builds found for version " + versionResponse.getVersion().getId()));
}

private boolean acceptableChannel(Channel channel, RequestedChannel requestedChannel) {
for (final Channel mapped : requestedChannel.getMappedTo()) {
if (mapped.equals(channel)) {
Expand Down
20 changes: 10 additions & 10 deletions src/test/resources/__files/paper/v3/projects_paper_versions_with_alphas.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,17 @@
}
},
"builds": [
49,
48,
47,
46,
45,
44,
42,
41,
40,
37,
38,
37
40,
41,
42,
44,
45,
46,
47,
48,
49
]
},
{
Expand Down