Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minecraft): allow values to fall back to server.properties default #145

Merged
merged 2 commits into from
Apr 1, 2023
Merged

feat(minecraft): allow values to fall back to server.properties default #145

merged 2 commits into from
Apr 1, 2023

Conversation

itzg
Copy link
Owner

@itzg itzg commented Mar 4, 2023

This solves these things:

  • simplifies the ugly, repetitive two lines of env name-values
  • provides a common mechanism to allow for null'ing out a value, such as --set minecraftServer.maxWorldSize=, leaving out the env var, and allowing server.properties value to be used instead.
  • gets rid of inconsistent/redundant use of default "" clauses

@billimek , if this looks good to you, then I'll do the same for the other three charts.

For #143

@itzg itzg requested a review from billimek March 4, 2023 23:04
@itzg itzg added the enhancement New feature or request label Mar 4, 2023
@itzg itzg marked this pull request as ready for review March 13, 2023 13:20
billimek
billimek approved these changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@billimek billimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the delay in reviewing!

@itzg
Copy link
Owner Author

itzg commented Apr 1, 2023

That's ok, I had forgotten I put this change out there 😀

@itzg itzg merged commit 4762ffb into master Apr 1, 2023
@itzg itzg deleted the feat/for-143 branch April 1, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billimek billimek billimek approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itzg @billimek