-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prometheus exporter for minecraft #25
base: master
Are you sure you want to change the base?
Conversation
|
Great contribution; however, I would prefer that it incorporate https://github.com/itzg/mc-monitor using its Prometheus exporter mode since that will work for all server types without any additional plugin. |
mc-monitor seems cool ! |
Let me know if it looks like it'll be too hard to add mc-monitor and the changes you have will be an excellent step in that direction. |
do you prefer to add a chart |
Since mc-monitor doesn't know how to do service discovery, then deploying as a side car makes more sense. |
itzg/mc-monitor crash after pod started, but it works when I run the code by
it said |
Oh yeah, that might be an edge case that the code isn't handling well. I'll try to look at that today. If I can get to that soon we can go with your original plan and then use a separate PR to add mc-monitor. |
lol. glad to find out the potential error |
0.6.1 now includes the fix |
@CasparChou are you wanting to continue with this? Happy to take over if not |
FYI to all interested in this, I'm going to resume work on this as part of my work on a minecraft-operator. Most of the operator code is based on these helm charts, so I'm happy to do any maintenance needed. That said, since this PR is almost 3 years old, I'm sure there has been plenty of drift and rather than try to resolve the conflicts, I'm just going to submit a totally new PR. Once filed, I will post a link to the new one here, for posterity. |
add prometheus exporter for minecraft
visualization game stats and jvm memory usage
by using Prometheus Operator (optional) and Prometheus Exporter Plugins (https://dev.bukkit.org/projects/prometheus-exporter)