Revert all layout changes #236
Conversation
This reverts commit 8908dbb.
This reverts commit 96d52fe.
… in lieu of runtime performance." This reverts commit 209a90d.
…ions" This reverts commit 540b2b7.
…er boundary optimization." This reverts commit 0344417.
This reverts commit 90a2043.
… from annotations" This reverts commit 92d44b1.
This reverts commit a7ab7f6.
This reverts commit 4f17ce3.
This reverts commit 2366e1e.
This reverts commit 924afa7.
…all cplex solver" This reverts commit f0ff4a6.
This reverts commit b5eb4c1.
This reverts commit c937d0c.
This reverts commit 583a207.
This reverts commit 45f39ad.
This reverts commit a90450f.
This reverts commit 5c811a5.
This reverts commit 4a8804c.
This reverts commit 6dbf340.
This reverts commit 985b98b.
This reverts commit 5827f62.
This reverts commit 0cb2be2.
This reverts commit fab882a.
This reverts commit 32d884b.
This reverts commit bc339a6.
This reverts commit 868c772.
This reverts commit a87fd43.
This reverts commit 4a51fec.
This reverts commit e554f1c.
|
It’s a rather big patch with only (mostly?) reverts. Could you maybe comment on what goal this PR sets? |
|
This PR is to revert all the layout changes that I had introduced to the main branch and instead make a PR request for all these changes so that they can be reviewed by multiple people and to ensure good code is merged. |
|
I see. Maybe then the reverts need not be reviewed? I think it'd make more sense to just merge them and then put all the attention we have to the actual changes when they're submitted as a PR. |
|
K, sounds good |
|
One thing for the future, though: this kind of PR should probably have contained only one committ so that not to pollute the history on the main branch. |
|
Yeah should squash before merging. For next time. A Readme for best practices might be helpful. |
|
You're absolutely right! Many OSS projects have a CONTRIBUTING.md document that describes things like this (see e.g. cabal: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md). Gibbon should absolutely get one too! |
I will make a PR for this.