Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: omit/ignore planner header when its value is empty #577

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: omit/ignore planner header when its value is empty #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
933b3ba
feat: add timestamp to notifications
ivan-lednev Sep 28, 2024
f5964ab
fix: fix 12 am parsed as noon
ivan-lednev Sep 28, 2024
4af69c5
feat: add active task end time in status bar
ivan-lednev Sep 28, 2024
6868c75
Merge branch 'ivan-lednev:main' into main
brianrodri Sep 28, 2024
22d2640
feat: append to end of file when plannerHeader is empty
brianrodri Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions src/service/plan-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,12 +173,12 @@ export class PlanEditor {
private async editFile(path: string, editFn: (contents: string) => string) {
await this.obsidianFacade.editFile(path, (contents) => {
const edited = editFn(contents);
const { plannerHeading, sortTasksInPlanAfterEdit } = this.settings();

if (!this.settings().sortTasksInPlanAfterEdit) {
if (!plannerHeading || !sortTasksInPlanAfterEdit) {
return edited;
}

const plannerHeading = this.settings().plannerHeading;
const mdastRoot = fromMarkdown(edited);
const headingWithChildren = findHeadingWithChildren(
mdastRoot,
Expand Down Expand Up @@ -214,15 +214,14 @@ export class PlanEditor {
contents: string[],
metadata: CachedMetadata,
): [number, string[]] {
const planHeading = getHeadingByText(
metadata,
this.settings().plannerHeading,
);
const { plannerHeading } = this.settings();

const planListItems = getListItemsUnderHeading(
metadata,
this.settings().plannerHeading,
);
if (!plannerHeading) {
return [contents.length, contents];
}

const planHeading = getHeadingByText(metadata, plannerHeading);
const planListItems = getListItemsUnderHeading(metadata, plannerHeading);

if (planListItems && planListItems?.length > 0) {
const lastListItem = planListItems[planListItems.length - 1];
Expand Down
2 changes: 1 addition & 1 deletion src/ui/settings-tab.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ export class DayPlannerSettingsTab extends PluginSettingTab {
new Setting(containerEl)
.setName("Planner Heading Text")
.setDesc(
`When you create a planner, this text is going to be in the heading`,
`When you create a planner, the events will be kept under this header. If empty, then events are placed at the bottom of the file.`,
)
.addText((component) =>
component
Expand Down