Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #20 fix #22

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Issue #20 fix #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f091270
Allows setting the Window to display the SPIndicator
PedroCavaleiro Nov 21, 2022
c102adc
Actually sets the Window to the SPIndicatorView
PedroCavaleiro Nov 21, 2022
039fcef
Changes SPIndicatorView to allow setting PresentOn
PedroCavaleiro Nov 21, 2022
526801b
ToPresentPosition fix to display proper position in custom window
PedroCavaleiro Nov 21, 2022
b9bb9cd
Removed custom Window set
PedroCavaleiro Nov 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Sources/SPIndicator/Extensions/SwiftUIExtension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import SwiftUI

#if os(iOS)

@available(iOS 13.0, *)
@available(iOSApplicationExtension, unavailable)

Expand Down
4 changes: 2 additions & 2 deletions Sources/SPIndicator/SPIndicatorView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ open class SPIndicatorView: UIView {

let getPrepareTransform: ((_ side: SPIndicatorPresentSide) -> CGAffineTransform) = { [weak self] side in
guard let self = self else { return .identity }
guard let window = UIApplication.shared.windows.first else { return .identity }
guard let window = self.presentWindow else { return .identity }
switch side {
case .top:
let topInset = window.safeAreaInsets.top
Expand All @@ -348,7 +348,7 @@ open class SPIndicatorView: UIView {

let getVisibleTransform: ((_ side: SPIndicatorPresentSide) -> CGAffineTransform) = { [weak self] side in
guard let self = self else { return .identity }
guard let window = UIApplication.shared.windows.first else { return .identity }
guard let window = self.presentWindow else { return .identity }
switch side {
case .top:
var topSafeAreaInsets = window.safeAreaInsets.top
Expand Down