DHCP improvements. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitermarkus
force-pushed
the
dhcp
branch
2 times, most recently
from
2705697
to
aac2ca7
Compare
|
@reitermarkus Ping me when you are done so that I can start reviewing. Or put the PR in Draft mode until it is ready. |
|
@ivmarkov, I think that's it for now. |
ivmarkov
requested changes
Dec 24, 2023
| @@ -63,7 +63,7 @@ members = [ | |||
| [workspace.dependencies] | |||
| embassy-futures = { version = "0.1", default-features = false } | |||
| embassy-sync = { version = "0.3", default-features = false } | |||
| embassy-time = { version = "0.1", default-features = false } | |||
There was a problem hiding this comment.
This currently breaks the CI build because feature embedded-svc still needs embassy-time 0.1.
I plan to update embedded-svc and all esp-idf-* crates shortly post Dec 28 though.
|
LGTM. Will merge later today once I'm back. Hope you don't mind if I don't merge the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small improvements to get this working in the
esp-wifi/embassy_access_pointexample.I guess some changes are not technically necessary to get it working, since I now figured out that the
DHCPOFFERresponse needs to be sent as a broadcast, at least if the client IP is0.0.0.0.