Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adapt changes to upstream embassy-net #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

showier-drastic
Copy link
Contributor

Commit embassy-rs/embassy@be0d977 made a rather large change to lifetime/generics semantics to embassy-net. Update edge-nal-embassy to adapt to it.

Tested to compile, but not tested to run yet.

@ivmarkov
Copy link
Owner

ivmarkov commented Oct 8, 2024

Yes - thank you!

I think we should wait for this PR to get merged as well, as it will bring even more changes to embassy-net (it will switch to the core::net types).

Given that the upstream PR that switches smoltcp to core::net types already got merged, I don't think the embassy-net one would be delayed by a lot, if at all.

@ivmarkov
Copy link
Owner

ivmarkov commented Oct 8, 2024

Also - you need to run cargo fmt

@AnthonyGrondin
Copy link
Contributor

Thank you for taking care of this. I believe we should also wait for embassy-rs/embassy#3368 as it allows implementing proper readable() / writable() for embassy

@showier-drastic
Copy link
Contributor Author

Understood, thanks for letting me know!

@AnthonyGrondin
Copy link
Contributor

Both PRs have been merged, so feel free to continue this PR with the needed changes.

Smoltcp and embassy-net haven't had a release yet, at the time of writing this, but we can get by with using patches, I believe.

@showier-drastic
Copy link
Contributor Author

Both PRs have been merged, so feel free to continue this PR with the needed changes.

Smoltcp and embassy-net haven't had a release yet, at the time of writing this, but we can get by with using patches, I believe.

Nice to hear that, I will update this PR hopefully in a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants