Partial configuration as parameters #3
Conversation
juanjoSanz
commented
Oct 19, 2023
juanjoSanz
commented
- Expose serial device into container
- Configurable parameters to set serial interface
my config.ini
set parameters
set serial from config
fix typo
config.ini generated from config
set config.ini location from data folder
take config.ini from data folder
nx584/config.yaml
Outdated
| @@ -11,3 +14,9 @@ arch: | |||
| - i386 | |||
| ports: | |||
| 5007/tcp: 5007 | |||
| options: | |||
| serial_dev: "/dev/serial/by-id/usb-Prolific_Technology_Inc._USB-Serial_Controller-if00-port0" | |||
There was a problem hiding this comment.
This is hard-coded to your own serial device. Ideally it should be something more generic?
There was a problem hiding this comment.
yes, that's my config, the idea is that this parameter can be easily set in addon config tab
debug mode
add debug to config
listener_address does not matter, it is a docker container
remove listener address parameter
There was a problem hiding this comment.
Overall looks good! A few small remaining changes/suggestions.
But most important - is this ready now? I'm unsure, as you keep pushing more and more stuff. If you plan to continue developing it before I merge, can you mark the PR as "Draft" so that at least I'm aware that this is still work in progress?
| baud: "9600" | ||
| socat: | ||
| enabled: false | ||
| host: "192.168.30.1" |
There was a problem hiding this comment.
Also here - let's change it to "192.168.0.1" which is kinda like the most popular network?
| euro_date_format: true | ||
| use_binary_protocol: false | ||
| idle_time_heartbeat_seconds: "120" | ||
| zones: "NX Main entrance,NX Kitchen,NX Despacho,NX Garage" |
There was a problem hiding this comment.
Also here: "Area 1, Area 2, ..."?
There was a problem hiding this comment.
I plan to do that, but it is still on development...
