Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Paddle Frontend: max_pool2d #23493

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

aibenStunner
Copy link
Contributor

PR Description

Related Issue

Close #23492

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 12, 2023
@aibenStunner
Copy link
Contributor Author

Hello @sondertg,
Can you please review the PR and let me know if any changes are needed? Thanks.

@TugayGul
Copy link
Contributor

TugayGul commented Oct 8, 2023

Hi @aibenStunner, thanks for your great effort. However, from CI tests, I see that tests are not passing. You may want to fix them. You can check falsifying examples, it is good point to start investigating the reasons behind those failures.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@aibenStunner aibenStunner changed the title Paddle Frontend: max_pool2d feat: Paddle Frontend: max_pool2d Nov 1, 2023
@TugayGul
Copy link
Contributor

TugayGul commented Nov 2, 2023

LGTM!

@TugayGul TugayGul merged commit 4bf62f3 into ivy-llc:main Nov 2, 2023
90 of 137 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

max_pool2d
3 participants