Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat gradients #776

Open
12 of 14 tasks
saeedashrraf opened this issue Apr 2, 2022 · 7 comments
Open
12 of 14 tasks

Reformat gradients #776

saeedashrraf opened this issue Apr 2, 2022 · 7 comments
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks

Comments

@saeedashrraf
Copy link
Contributor

saeedashrraf commented Apr 2, 2022

As explained in the function reformatting open task, each function in the gradients submodule should be updated to follow the implementation instructions given in the Deep Dive section of the docs. The updates should be applied for both the Ivy API and Backend API. The Deep Dive is the best general resource for learning in detail how functions should be implemented. Many of the functions are not implemented as they should be. You will need to make changes to the current implementations, but you do not need to go through all section of the Deep Dive. Specifically, you should make the following changes, where appropriate:

  1. remove all lambda and direct bindings for backend functions, with each function instead defined using def.
  2. update the function arguments and type hints.
  3. add the correct docstrings
  4. add thorough docstring examples

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.

_

The main file paths where these functions are likely to be added are:

  • ivy/functional/ivy/gradients.py
  • ivy/array/gradients.py
  • ivy/container/gradients.py
  • ivy/functional/backends/jax/gradients.py
  • ivy/functional/backends/tensorflow/gradients.py
  • ivy/functional/backends/torch/gradients.py
@saeedashrraf saeedashrraf added ToDo A ToDo list of tasks Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide labels Apr 2, 2022
@ivy-llc ivy-llc deleted a comment from Joanes-Iri May 30, 2022
@ivy-llc ivy-llc deleted a comment from fnhirwa Jun 27, 2022
@ivy-llc ivy-llc deleted a comment from Psychofun Jul 5, 2022
@ivy-llc ivy-llc deleted a comment from sampreet-arthi Jul 5, 2022
@ivy-llc ivy-llc deleted a comment from fnhirwa Jul 6, 2022
@ivy-llc ivy-llc deleted a comment from yugaljain1999 Jul 12, 2022
@ivy-llc ivy-llc deleted a comment from Accumulated Jul 25, 2022
@ivy-llc ivy-llc deleted a comment from someshfengde Jul 25, 2022
@ivy-llc ivy-llc deleted a comment from yugaljain1999 Jul 25, 2022
@vandit98 vandit98 mentioned this issue Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from VikramxD Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from fnhirwa Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from vandit98 Jul 27, 2022
@ivy-llc ivy-llc deleted a comment from DrashtySoni Aug 1, 2022
@ivy-llc ivy-llc deleted a comment from peacemakafui Aug 1, 2022
@ivy-llc ivy-llc deleted a comment from dhakalaashish Dec 28, 2022
@ivy-llc ivy-llc deleted a comment from waheeduddin Jan 2, 2023
@ivy-llc ivy-llc deleted a comment from CaloloCosta Jan 10, 2023
@ivy-llc ivy-llc deleted a comment from NouranYoussef Feb 19, 2023
@ivy-llc ivy-llc deleted a comment from mail2sia Mar 13, 2023
@ivy-llc ivy-llc deleted a comment from ManasVardhan Mar 21, 2023
@a0m0rajab
Copy link
Contributor

If we look at the check list it seems like all the functions here has been merged, but it seems that:

  • set_with_grads
  • lars_update
  • adam_update
  • lamb_update
    has no merged PRs, are they fixed or are they still open for contribution?
    @saeedashrraf

@TangoIndiaMango
Copy link

@a0m0rajab
according to the functions you posted, did you get a reply for a go ahead?

@a0m0rajab
Copy link
Contributor

@TangoIndiaMango not yet, if I got something it would be written in this issue.

@rehanganapathy
Copy link

Hey I'd like to work on this issue if it hasn't been resolved yet

@ivy-llc ivy-llc deleted a comment from Abhinav-CHD Sep 20, 2023
@Abhinav-CHD Abhinav-CHD mentioned this issue Sep 21, 2023
5 tasks
@ivy-llc ivy-llc deleted a comment from jdboachie Sep 23, 2023
@a0m0rajab a0m0rajab added the hacktoberfest hacktoberfest label Sep 25, 2023
@ivy-llc ivy-llc deleted a comment from ramstar3000 Sep 27, 2023
@tbeetech
Copy link
Contributor

tbeetech commented Oct 1, 2023

  • set_with_grads

@tbeetech
Copy link
Contributor

tbeetech commented Oct 1, 2023

  • lamb_update

@Janhavipadhi
Copy link

unset_with_grads #26865

@ivy-llc ivy-llc deleted a comment from JoshOlam Oct 23, 2023
@ivy-llc ivy-llc deleted a comment from zeeshan0804 Oct 25, 2023
@ivy-llc ivy-llc deleted a comment from yowayb Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Function Reformatting Reformat all Ivy functions in accordance with the latest coding style in the contributor guide hacktoberfest hacktoberfest ToDo A ToDo list of tasks
Projects
None yet
Development

No branches or pull requests

8 participants