Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reformat lars_update #25770

Merged
merged 1 commit into from
Sep 25, 2023
Merged

reformat lars_update #25770

merged 1 commit into from
Sep 25, 2023

Conversation

Abhinav-CHD
Copy link
Contributor

@Abhinav-CHD Abhinav-CHD commented Sep 21, 2023

Added functional examples to the lars_update function resolves #25688

Reformat gradients #776

Close #25688

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials: https://twitter.com/Abhinav_ems

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for supporting Ivy! 🎉
Join the conversation in our Discord

Here are some notes to understand our tests:

  • We have merged all the tests in one file called `display_test_results` job. 👀 It contains the following two sections:
    • Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
    • New Failures Introduced: This lists the tests that fails on this PR.

Please make sure they are passing. 💪

Keep in mind that we will assign an engineer for this task and they will look at it based on the workload that they have, kindly be patient 😄.

@ivy-leaves ivy-leaves added Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy Functional API labels Sep 21, 2023
@Abhinav-CHD
Copy link
Contributor Author

Hey I believe some of the test cases are not passing. Could you please help me with that?

Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, but I'll leave this with @RickSanchezStoic to review as he's assigned to the PR (the automation auto-requested my review due to changes to the gradients files). Thanks @Abhinav-CHD 😄

@Abhinav-CHD
Copy link
Contributor Author

@vedpatwardhan Thank you. It was an honor to contribute to Ivy.

@RickSanchezStoic
Copy link
Contributor

lgtm!

@RickSanchezStoic RickSanchezStoic merged commit 975c8fc into ivy-llc:main Sep 25, 2023
529 of 537 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
Added functional examples to the lars_update function resolves ivy-llc#25688
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Added functional examples to the lars_update function resolves ivy-llc#25688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Array API Conform to the Array API Standard, created by The Consortium for Python Data API Standards Ivy Functional API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lars_update
4 participants