Smooth L1 loss added to Experimental API #13163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnhirwa
suggested changes
Mar 30, 2023
There was a problem hiding this comment.
Hey @DebadityaPal
Thanks for contributing to ivy😊
Would you add unit tests for this function🙂
Thanks
DebadityaPal
force-pushed
the
smooth_l1_loss
branch
from
bf60c01 to
9eabb03
Compare
|
Force pushed to rebase with master branch |
fnhirwa
suggested changes
Apr 3, 2023
There was a problem hiding this comment.
Hey @DebadityaPal
Thanks for implementing the unit tests😊
But still they are failing would you check them from your end and fix the failures accordingly.
Thanks
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13159