adding putmask and its test #18972

ShreyanshBardia · 2023-07-07T22:39:48Z

bipinKrishnan · 2023-07-11T12:11:12Z

Thanks for the contribution @ShreyanshBardia 🙂 . Can you fix the failing test for paddle backend?
Also, it would be nice if you install pre-commit and run it before making a commit, so that the lint checks are done correctly before pushing. Thanks

bipinKrishnan · 2023-07-11T12:12:07Z

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

ShreyanshBardia · 2023-07-11T17:12:15Z

@bipinKrishnan surely will run precommit beforehand. As for the paddle test case, I am not sure if that is being caused by my PR. A similar test case was failing for #18334, but it appears to be unrelated to the PR. Can you confirm if this is the same case, if not I'll make the required changes.

ShreyanshBardia · 2023-07-14T10:24:44Z

Hi @bipinKrishnan can you check this once

bipinKrishnan · 2023-07-17T11:44:29Z

ivy/functional/frontends/numpy/indexing_routines/inserting_data_into_arrays.py

+        return
+    if values.size != a.size:
+        values = np_frontend.resize(values, a.shape)
+    a[mask] = values[mask]


I think you forgot the return for this function

According to the documentation, the function doesn't return anything rather changes the array in place. Here is the relevant link

ivy-seed · 2023-07-26T05:53:20Z

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ShreyanshBardia · 2023-07-26T09:45:44Z

Hi @bipinKrishnan, could you please take a look at this.

…into numpy-putmask

bipinKrishnan · 2023-07-28T12:06:15Z

Hey @ShreyanshBardia , can you fix the failing the test for the function you added, currently failing for the paddle backend

ShreyanshBardia · 2023-08-03T09:05:30Z

Hi @bipinKrishnan, as I mentioned earlier I think the failure is unrelated to the PR, a similar test was failing here #18334 (review) which turned out to be unrelated. Would be glad if you could confirm that

bipinKrishnan · 2023-08-08T12:34:42Z

Ok, let me check this

ivy-seed · 2023-08-20T05:53:36Z

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

ShreyanshBardia · 2023-08-21T12:17:19Z

Hi @bipinKrishnan, can you take a look at the PR now, I have updated the branch and also updates the test function, since putmask doesn't return anything and changed inplace it is better to test it directly using helpers.value_test. All the tests are passing for me locally

ShreyanshBardia · 2023-08-21T12:21:26Z

@bipinKrishnan It seems an old docker image is being used to test and since I updated my branch, a new dependency that was recently added dill is causing the tests to fail

bipinKrishnan · 2023-08-22T10:58:29Z

It would be great if you could configure pre-commit in your system to avoid lint test fails. Thanks!

bipinKrishnan · 2023-08-22T10:58:39Z

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

bipinKrishnan · 2023-08-22T11:04:43Z

@bipinKrishnan It seems an old docker image is being used to test and since I updated my branch, a new dependency that was recently added dill is causing the tests to fail

The team is looking into this issue, let's see how the testing goes once this is fixed. Thanks!

bipinKrishnan · 2023-08-22T11:21:25Z

Hey @ShreyanshBardia , the issue with dill is fixed now, can you rebase on top of main and try again?

ShreyanshBardia · 2023-08-22T11:36:31Z

Hi, I do have pre-commit configured but I guess this might have been caused when I was resolving merge conflicts using web browser. Apologies for that. It looks like tests ran and were successful can you check @bipinKrishnan

bipinKrishnan · 2023-09-06T19:06:40Z

ivy/functional/frontends/numpy/indexing_routines/inserting_data_into_arrays.py

@@ -31,6 +31,15 @@ def fill_diagonal(a, val, wrap=False):
    a = ivy.reshape(temp, shape)


+@to_ivy_arrays_and_back
+def putmask(a, mask, values, /):


You could remove the / as it doesn't make sense because there are no kwargs after that

Oh correct, thanks for catching this, I have updated it correctly now @bipinKrishnan

bipinKrishnan · 2023-09-06T19:23:16Z

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

ShreyanshBardia · 2023-09-10T16:00:38Z

@bipinKrishnan can you take a look

adding putmask and its test

a9482a0

ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Jul 7, 2023

ivy-seed assigned bipinKrishnan Jul 7, 2023

🤖 Lint code

868ee90

bipinKrishnan reviewed Jul 17, 2023

View reviewed changes

ShreyanshBardia requested a review from bipinKrishnan July 17, 2023 11:51

ivy-seed added the Stale label Jul 26, 2023

ShreyanshBardia added 2 commits July 26, 2023 15:28

added new backend_to_test param

d28e75c

Merge branch 'numpy-putmask' of https://github.com/ShreyanshBardia/ivy …

6a41abf

…into numpy-putmask

bipinKrishnan removed the Stale label Jul 28, 2023

ivy-seed added the Stale label Aug 20, 2023

ShreyanshBardia and others added 2 commits August 21, 2023 17:08

Merge branch 'main' into numpy-putmask

1a5b16c

updated test

3512e35

🤖 Lint code

3991337

bipinKrishnan reviewed Sep 6, 2023

View reviewed changes

Merge branch 'main' into numpy-putmask

8ab2c40

bipinKrishnan removed the Stale label Sep 6, 2023

ivy-branch and others added 2 commits September 6, 2023 19:24

🤖 Lint code

b270d10

correct the positional argument character

a200e4c

ShreyanshBardia closed this Sep 13, 2023

ShreyanshBardia deleted the numpy-putmask branch September 13, 2023 19:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding putmask and its test #18972

adding putmask and its test #18972

ShreyanshBardia commented Jul 7, 2023

bipinKrishnan commented Jul 11, 2023 •

edited

Loading

bipinKrishnan commented Jul 11, 2023 •

edited by ivy-branch

Loading

ShreyanshBardia commented Jul 11, 2023 •

edited

Loading

ShreyanshBardia commented Jul 14, 2023

bipinKrishnan Jul 17, 2023

ShreyanshBardia Jul 17, 2023

ivy-seed commented Jul 26, 2023

ShreyanshBardia commented Jul 26, 2023

bipinKrishnan commented Jul 28, 2023

ShreyanshBardia commented Aug 3, 2023

bipinKrishnan commented Aug 8, 2023

ivy-seed commented Aug 20, 2023

ShreyanshBardia commented Aug 21, 2023 •

edited

Loading

ShreyanshBardia commented Aug 21, 2023

bipinKrishnan commented Aug 22, 2023 •

edited

Loading

bipinKrishnan commented Aug 22, 2023 •

edited by ivy-branch

Loading

bipinKrishnan commented Aug 22, 2023

bipinKrishnan commented Aug 22, 2023

ShreyanshBardia commented Aug 22, 2023

bipinKrishnan Sep 6, 2023

ShreyanshBardia Sep 7, 2023

bipinKrishnan commented Sep 6, 2023 •

edited by ivy-branch

Loading

ShreyanshBardia commented Sep 10, 2023

adding putmask and its test #18972

adding putmask and its test #18972

Conversation

ShreyanshBardia commented Jul 7, 2023

bipinKrishnan commented Jul 11, 2023 • edited Loading

bipinKrishnan commented Jul 11, 2023 • edited by ivy-branch Loading

ShreyanshBardia commented Jul 11, 2023 • edited Loading

ShreyanshBardia commented Jul 14, 2023

bipinKrishnan Jul 17, 2023

Choose a reason for hiding this comment

ShreyanshBardia Jul 17, 2023

Choose a reason for hiding this comment

ivy-seed commented Jul 26, 2023

ShreyanshBardia commented Jul 26, 2023

bipinKrishnan commented Jul 28, 2023

ShreyanshBardia commented Aug 3, 2023

bipinKrishnan commented Aug 8, 2023

ivy-seed commented Aug 20, 2023

ShreyanshBardia commented Aug 21, 2023 • edited Loading

ShreyanshBardia commented Aug 21, 2023

bipinKrishnan commented Aug 22, 2023 • edited Loading

bipinKrishnan commented Aug 22, 2023 • edited by ivy-branch Loading

bipinKrishnan commented Aug 22, 2023

bipinKrishnan commented Aug 22, 2023

ShreyanshBardia commented Aug 22, 2023

bipinKrishnan Sep 6, 2023

Choose a reason for hiding this comment

ShreyanshBardia Sep 7, 2023

Choose a reason for hiding this comment

bipinKrishnan commented Sep 6, 2023 • edited by ivy-branch Loading

ShreyanshBardia commented Sep 10, 2023

bipinKrishnan commented Jul 11, 2023 •

edited

Loading

bipinKrishnan commented Jul 11, 2023 •

edited by ivy-branch

Loading

ShreyanshBardia commented Jul 11, 2023 •

edited

Loading

ShreyanshBardia commented Aug 21, 2023 •

edited

Loading

bipinKrishnan commented Aug 22, 2023 •

edited

Loading

bipinKrishnan commented Aug 22, 2023 •

edited by ivy-branch

Loading

bipinKrishnan commented Sep 6, 2023 •

edited by ivy-branch

Loading