add fft2 function to paddlepaddle frontend! #19058
Conversation
|
Close #19052 |
ivy-leaves
added
the
Paddle Frontend
|
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
|
I am working on to-do list. I have created the pr. please do review it and let me know if any changes are required. |
|
Hey @ArsalanAli915 , I couldn't see any todo list task that is linked to the issue mentioned, may be you forgot to comment in the todo list issue. Also, it works best when you add "Close " in the first comment of the PR, I'll just manually link the issue for now. Thanks 🙂 |
|
hey @bipinKrishnan could you please tell me how long you would take to review it before we can merge the pr. |
|
hey @bipinKrishnan could you please give me feedback so that we can merge it. |
|
This might be the to-do list you got the task from - #15047 .Please link it as I mentioned earlier. |
|
@bipinKrishnan I have linked the issue and also add the "Closed #issue_number" in pr. please check it out. |
| ) | ||
| @to_ivy_arrays_and_back | ||
| def fft2(x, n=None, axes=(- 2, - 1), norm='backward', name=None): | ||
| ret = ivy.fft2(ivy.astype(x, "complex128"), axes, norm=norm, n=n) |
There was a problem hiding this comment.
If you have any specific reason for converting to complex128, let me know. Also ivy.fft2 doesn't take n as an argument.
There was a problem hiding this comment.
@bipinKrishnan I have updated the function there is no specific reason for implementing the complex128. please do let me know if other changes are required.
There was a problem hiding this comment.
In that case, can you remove these type casting to avoid overheads? Also please make the other change about n argument that I mentioned in the comment above.
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
No description provided.