Implemented testing for copy #19683
Implemented testing for copy #19683
Conversation
| @@ -309,6 +314,18 @@ def test_function( | |||
| target_fn, *args, test_compile=test_flags.test_compile, **kwargs | |||
| ) | |||
|
|
|||
| if test_flags.with_copy: | |||
| array_fn = ivy.is_array | |||
| if "copy" in list(inspect.signature(target_fn).parameters.keys()): | |||
There was a problem hiding this comment.
We shouldn't do this kind of search in arguments for each example, but instead this logic should be moved into the decorator where this is done only once.
There was a problem hiding this comment.
By decorator, do you mean the handle_frontend_test and handle_test decorator?
KevinUli
force-pushed
the
test_for_copy
branch
from
c5b1b17 to
2bbec50
Compare
# Conflicts: # ivy_tests/test_ivy/helpers/function_testing.py
KevinUli
force-pushed
the
test_for_copy
branch
from
97ac897 to
4b53291
Compare
# Conflicts: # ivy_tests/test_ivy/helpers/function_testing.py # ivy_tests/test_ivy/helpers/test_parameter_flags.py # ivy_tests/test_ivy/helpers/testing_helpers.py
# Conflicts: # ivy_tests/test_ivy/helpers/function_testing.py # ivy_tests/test_ivy/helpers/test_parameter_flags.py # ivy_tests/test_ivy/helpers/testing_helpers.py
|
Hey @sherry30, could you review this? We have dragged this for 2 months now 😅 And I would say it's an important feature missing from the pipeline. |
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
|
I have made the changes requested. I also updated the return call for the ivy API tests to include |
No description provided.