-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation to precise mode #22762
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MahmoudAshraf97,
LGTM overall, I've left some comments that I want to know what do you think about them. I guess we also may need to add some examples, I guess one example for precise mode and one for non-precise would be enough
Co-authored-by: Kareem Morsy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: Kareem Morsy <[email protected]>
PR Description
This PR adds documentation to Precision mode to datatypes deepdive
it is still missing some code examples but I don't know if they are needed