Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: ivy.compile( ) updated to ivy.trace_graph( ) #22764

Merged
merged 25 commits into from
Oct 2, 2023

Conversation

HaiderSultanArc
Copy link
Contributor

@HaiderSultanArc HaiderSultanArc commented Aug 30, 2023

We are updating our ivy.compile( ) function to ivy.trace_graph( ) function.
This requires updating the Docs, Ivy Repo, Graph Compiler Repo, Demos, and other places to refer to Tracer rather than Graph Compiler!

This PR updates Docs!

@HaiderSultanArc HaiderSultanArc added the Documentation Issues or bugs that are found anywhere in documentation label Aug 30, 2023
@HaiderSultanArc HaiderSultanArc self-assigned this Aug 30, 2023
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@KareemMAX
Copy link
Contributor

I think I missed the discussion where we are renaming the compiler to tracer. Can you please link that to me? And I believe @guillesanbri would be the best one to review those changes

@HaiderSultanArc
Copy link
Contributor Author

I think I missed the discussion where we are renaming the compiler to tracer. Can you please link that to me? And I believe @guillesanbri would be the best one to review those changes

Here you go @KareemMAX 😄:
https://discord.com/channels/799879767196958751/1088437511925272717/1144634211920248947

Copy link
Contributor

@guillesanbri guillesanbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments 😄

Not sure if you are working on that, but would you mind going over the demos and making the relevant changes there as well?

Also I haven't checked but I assume that some images on the docs need to be updated to reflect these changes

Also, take into account that this shouldn't be merged until we have the changes ready in the functions and a new .so file with the corresponding updated functions is ready 👍

README.md Outdated Show resolved Hide resolved
docs/overview/deep_dive/ivy_frontends.rst Outdated Show resolved Hide resolved
docs/overview/deep_dive/ivy_frontends.rst Outdated Show resolved Hide resolved
docs/overview/design/building_blocks.rst Outdated Show resolved Hide resolved
docs/overview/related_work/graph_tracers.rst Outdated Show resolved Hide resolved
docs/tracer/setting_up.rst Outdated Show resolved Hide resolved
docs/tracer/tracer.rst Outdated Show resolved Hide resolved
docs/tracer/tracer.rst Outdated Show resolved Hide resolved
docs/tracer/tracer.rst Outdated Show resolved Hide resolved
@HaiderSultanArc
Copy link
Contributor Author

HaiderSultanArc commented Aug 30, 2023

Left a couple of comments 😄

Not sure if you are working on that, but would you mind going over the demos and making the relevant changes there as well?

Also I haven't checked but I assume that some images on the docs need to be updated to reflect these changes

Also, take into account that this shouldn't be merged until we have the changes ready in the functions and a new .so file with the corresponding updated functions is ready 👍

Hey @guillesanbri, I am working on updating it all across. In demos, ivy repo and graph compiler repo. I only updated Docs fist to get a review. We'll merge this PR after I update it in code as well! ✨ Thanks for the reviews 😄

@HaiderSultanArc HaiderSultanArc changed the title Docs: ivy.compile( ) updated to ivy.trace( ) Update: ivy.compile( ) updated to ivy.trace( ) Aug 30, 2023
@guillesanbri
Copy link
Contributor

Left a couple of comments 😄
Not sure if you are working on that, but would you mind going over the demos and making the relevant changes there as well?
Also I haven't checked but I assume that some images on the docs need to be updated to reflect these changes
Also, take into account that this shouldn't be merged until we have the changes ready in the functions and a new .so file with the corresponding updated functions is ready 👍

Hey @guillesanbri, I am working on updating it all across. In demos, ivy repo and graph compiler repo. I only updated Docs fist to get a review. We'll merge this PR after I update it in code as well! ✨ Thanks for the reviews 😄

Sounds good, let me know if I can help with anything :D

@HaiderSultanArc HaiderSultanArc linked an issue Aug 31, 2023 that may be closed by this pull request
6 tasks
@HaiderSultanArc HaiderSultanArc linked an issue Aug 31, 2023 that may be closed by this pull request
@HaiderSultanArc HaiderSultanArc changed the title Update: ivy.compile( ) updated to ivy.trace( ) Update: ivy.compile( ) updated to ivy.trace_graph( ) Sep 26, 2023
Copy link
Contributor

@guillesanbri guillesanbri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the files under tracer and under one_liners are duplicated? Would be good to also build the docs in the branch and see if the links work fine etc.

Just left a few comments aside from the duplicate files, once these are resolved prob this is ready to merge

However let's wait until we have updated the hiring stuff as well, will update on this front later today / tomorrow

docs/overview/deep_dive/ivy_frontends_tests.rst Outdated Show resolved Hide resolved
docs/overview/faq.rst Outdated Show resolved Hide resolved
docs/overview/glossary.rst Outdated Show resolved Hide resolved
@HaiderSultanArc
Copy link
Contributor Author

Left a couple of comments 😄

Not sure if you are working on that, but would you mind going over the demos and making the relevant changes there as well?

Also I haven't checked but I assume that some images on the docs need to be updated to reflect these changes

Also, take into account that this shouldn't be merged until we have the changes ready in the functions and a new .so file with the corresponding updated functions is ready 👍

There's no "Compiler" folder which I changed to "Tracer" so I should just remove it now 🤔

@HaiderSultanArc HaiderSultanArc merged commit 39671b3 into ivy-llc:main Oct 2, 2023
137 checks passed
@HaiderSultanArc HaiderSultanArc deleted the compile_to_trace branch October 2, 2023 18:50
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues or bugs that are found anywhere in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs
4 participants