-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: ivy.compile( ) updated to ivy.trace_graph( ) #22764
Update: ivy.compile( ) updated to ivy.trace_graph( ) #22764
Conversation
Thanks for contributing to Ivy! 😊👏 |
I think I missed the discussion where we are renaming the compiler to tracer. Can you please link that to me? And I believe @guillesanbri would be the best one to review those changes |
Here you go @KareemMAX 😄: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of comments 😄
Not sure if you are working on that, but would you mind going over the demos and making the relevant changes there as well?
Also I haven't checked but I assume that some images on the docs need to be updated to reflect these changes
Also, take into account that this shouldn't be merged until we have the changes ready in the functions and a new .so file with the corresponding updated functions is ready 👍
Hey @guillesanbri, I am working on updating it all across. In demos, ivy repo and graph compiler repo. I only updated Docs fist to get a review. We'll merge this PR after I update it in code as well! ✨ Thanks for the reviews 😄 |
Sounds good, let me know if I can help with anything :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the files under tracer
and under one_liners
are duplicated? Would be good to also build the docs in the branch and see if the links work fine etc.
Just left a few comments aside from the duplicate files, once these are resolved prob this is ready to merge
However let's wait until we have updated the hiring stuff as well, will update on this front later today / tomorrow
There's no "Compiler" folder which I changed to "Tracer" so I should just remove it now 🤔 |
…/ivy into compile_to_trace
Co-authored-by: ivy-branch <[email protected]>
We are updating our
ivy.compile( )
function toivy.trace_graph( )
function.This requires updating the Docs, Ivy Repo, Graph Compiler Repo, Demos, and other places to refer to Tracer rather than Graph Compiler!
This PR updates Docs!