Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated imports from the test layers in numpy.fft #22786

Closed
wants to merge 1 commit into from
Closed

Updated imports from the test layers in numpy.fft #22786

wants to merge 1 commit into from

Conversation

humzakt
Copy link
Contributor

@humzakt humzakt commented Aug 30, 2023

PR Description

The funciton names in nn.layers for composite functions for ifft and rfftn were updated previously which messed up the imports in numpy.fft file

I updated the imports of these composite functions and re ran the tests functions which are now functional. Previously they stopped working due to incorrect imports rendering the complete file causing errors

Socials:

twitter.com/humzakt

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Aug 30, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

Copy link
Contributor

@umairjavaid umairjavaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing. I am not sure why you made these changes

E   ivy.utils.exceptions.IvyBackendException: tensorflow: dft: tensorflow: fft: Value for attr 'Tcomplex' of double is not in the list of allowed values: complex64, complex128
E   	; NodeDef: {{node FFT}}; Op<name=FFT; signature=input:Tcomplex -> output:Tcomplex; attr=Tcomplex:type,default=DT_COMPLEX64,allowed=[DT_COMPLEX64, DT_COMPLEX128]> [Op:FFT] name: 2 points FFT at dim 0 with backward normalization
E   Falsifying example: test_numpy_rfft(
E       backend_fw='tensorflow',
E       frontend='numpy',
E       on_device='cpu',
E       dtype_input_axis=(['complex64'],
E        [array([-1.-1.j, -1.-1.j], dtype=complex64)],
E        0),
E       norm='backward',
E       n=2,
E       test_flags=FrontendFunctionTestFlags(
E           num_positional_args=0,
E           with_out=False,
E           inplace=False,
E           as_variable=[False],
E           native_arrays=[False],
E           test_compile=False,
E           generate_frontend_arrays=False,
E           precision_mode=False,
E       ),
E       fn_tree='ivy.functional.frontends.numpy.fft.rfft',
E   )
E   
E   You can reproduce this example by temporarily adding @reproduce_failure('6.82.7', b'AXicY2BgYGBkgABGItkQAAABOgAJ') as a decorator on your test case

@umairjavaid umairjavaid removed their assignment Oct 16, 2023
@humzakt humzakt closed this by deleting the head repository Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants