Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlogy_ #22821

Merged
merged 3 commits into from
Sep 3, 2023
Merged

xlogy_ #22821

merged 3 commits into from
Sep 3, 2023

Conversation

NiteshK84
Copy link
Contributor

PR Description

adds xlogy_ function to torch frontend

Related Issue

Close #21868

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 31, 2023
@NiteshK84 NiteshK84 changed the title xology_ xlogy_ Aug 31, 2023
@Pchatain
Copy link
Contributor

Pchatain commented Sep 2, 2023

Hi @NiteshK84 nice work! Do you happen to know why the lint check formatting is failing? I can't immediately tell from looking at the code.

Edit: It actually looks like it's due to line 489 https://github.com/unifyai/ivy/blob/77b0bea53593f02940709c025a37a2d30fd69626/ivy/functional/frontends/torch/tensor.py#L489

ne = not_equal

and then it get's redefined in code that you did not write. So looks like an unrelated problem actually.

@NiteshK84
Copy link
Contributor Author

NiteshK84 commented Sep 2, 2023

@Pchatain, yeah because at line 1889 chrome_npM1Dnb6ij
we are redefining the ne function again after aliasing it with not_equal function at line 489
chrome_JdZ48uVU3i

@NiteshK84
Copy link
Contributor Author

i think we should remove the redefinition of ne from here
chrome_Qa5kXLewOT

@NiteshK84
Copy link
Contributor Author

but anyways this code has is unrelated with that issue and is ready to merge.
thanks😊

@aparajith21
Copy link
Contributor

Failures seem unrelated, LGTM, thanks for contributing!

@aparajith21 aparajith21 merged commit 3a10637 into ivy-llc:main Sep 3, 2023
127 of 133 checks passed
@NiteshK84 NiteshK84 deleted the xology_-T2 branch September 3, 2023 19:01
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xlogy_
4 participants