Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reciprocal inplace function in paddle and passed all tests #22824

Merged
merged 8 commits into from
Sep 3, 2023

Conversation

ArsalanAli915
Copy link
Contributor

@ArsalanAli915 ArsalanAli915 commented Aug 31, 2023

Close #22818

PR Description

Related Issue

Close #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ArsalanAli915
Copy link
Contributor Author

ArsalanAli915 commented Aug 31, 2023

c2
@rishabgit Passed all test. please do let me know if anything needs to change.

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 31, 2023
@ArsalanAli915
Copy link
Contributor Author

@rishabgit It passes lint check check too. please do take a look so that we can merge it.

@ArsalanAli915
Copy link
Contributor Author

@rishabgit please review as It is ready to merge from my side. please do let me know if I need to change anything.

@rishabgit rishabgit mentioned this pull request Sep 3, 2023
@rishabgit
Copy link
Contributor

Hi, your comment syntax wasn't right in the ToDo board and was picked up someone else before, but they hadn't started a PR yet, so I closed their issue and assigned your PR manually. Please use the correct syntax as mentioned in the docs in the future 😅

Your PR looks good to me otherwise! Thanks for adding this 😄

@rishabgit rishabgit merged commit fc3cd0d into ivy-llc:main Sep 3, 2023
113 of 133 checks passed
@ArsalanAli915
Copy link
Contributor Author

@rishabgit Thanks for merging the PR. Could you help me with this linking of the Issues in the To-do list? I have all three methods: - [ ] #Issue_number, #12345, and this one #12345. Neither of these links the issue. Previously I have linked with this method - [ ] #Issue_number and this works fine all the time. I also linked this one using this method, but I don't why it hasn't been linked. Please do let me know If I have any mistakes while linking so that I improve it and avoid problems.

@ArsalanAli915 ArsalanAli915 deleted the reciprocal_ branch September 3, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reciprocal_
3 participants