Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exp_ #22831

Merged
merged 8 commits into from
Sep 3, 2023
Merged

Exp_ #22831

merged 8 commits into from
Sep 3, 2023

Conversation

ArsalanAli915
Copy link
Contributor

@ArsalanAli915 ArsalanAli915 commented Aug 31, 2023

Close #22829

PR Description

Related Issue

Close #

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 31, 2023
@ArsalanAli915
Copy link
Contributor Author

@nassimberrada please do review the PR. It is passing all test on my End.

@nassimberrada
Copy link
Contributor

Hey @ArsalanAli915, thank you for contributing. I cannot review your PR yet as it hasn't been assigned to the corresponding function on the To-Do list issue. Feel free to request a review once you get assigned this function. Thanks!
(A quick comment though, I see in the tests you've set fn_tree="paddle.reciprocal" which points to another function, not exp_ which you're trying to implement.)

@ArsalanAli915
Copy link
Contributor Author

@nassimberrada Thanks for giving the review. I Have replace the exp test case and now it is passing all the test cases successfully. As far as a link with the Todo list, I believe that is the problem on the Ivy side. Since I have commented on the Issue number on the to-do list. Please do what is needed. Thanks.

@ArsalanAli915
Copy link
Contributor Author

@nassimberrada Could you please link this Issue manually, I have tried all methods of link written in doc https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues. All tests are passed successfully. It would really helpful if you could merge it.

@nassimberrada
Copy link
Contributor

Looks good to me, just linked the issue to the list. Thanks again for contributing!

@nassimberrada nassimberrada merged commit f99dbb6 into ivy-llc:main Sep 3, 2023
114 of 133 checks passed
@ArsalanAli915 ArsalanAli915 deleted the exp_ branch September 4, 2023 16:23
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp_
3 participants