-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exp_ #22831
Exp_ #22831
Conversation
Thanks for contributing to Ivy! 😊👏 |
@nassimberrada please do review the PR. It is passing all test on my End. |
Hey @ArsalanAli915, thank you for contributing. I cannot review your PR yet as it hasn't been assigned to the corresponding function on the To-Do list issue. Feel free to request a review once you get assigned this function. Thanks! |
@nassimberrada Thanks for giving the review. I Have replace the exp test case and now it is passing all the test cases successfully. As far as a link with the Todo list, I believe that is the problem on the Ivy side. Since I have commented on the Issue number on the to-do list. Please do what is needed. Thanks. |
@nassimberrada Could you please link this Issue manually, I have tried all methods of link written in doc https://unify.ai/docs/ivy/overview/contributing/the_basics.html#todo-list-issues. All tests are passed successfully. It would really helpful if you could merge it. |
Looks good to me, just linked the issue to the list. Thanks again for contributing! |
Close #22829
PR Description
Related Issue
Close #
Checklist
Socials: