Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unique_consecutive #22832

Merged
merged 3 commits into from
Sep 4, 2023
Merged

unique_consecutive #22832

merged 3 commits into from
Sep 4, 2023

Conversation

NiteshK84
Copy link
Contributor

@NiteshK84 NiteshK84 commented Aug 31, 2023

PR Description

Adds unique_consecutive func to torch frontend

Related Issue

Close #22828

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@NiteshK84 NiteshK84 changed the title added func and test unique_consecutive Aug 31, 2023
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Aug 31, 2023
@KevinUnadkat
Copy link
Contributor

hy @NiteshK84 , everything seems good , but have you tested the function locally .

@NiteshK84
Copy link
Contributor Author

Hi @KevinUnadkat i did test locally and all the test cases passed for all backend.
thanks

@NiteshK84
Copy link
Contributor Author

okay, actually i just checked the CI test failure, and i updated the test, sorry for the Inconvenience.

@KevinUnadkat
Copy link
Contributor

hy @NiteshK84
Everything seems to be ok now,
Thanks for Contributing.

@KevinUnadkat KevinUnadkat merged commit e1f93d2 into ivy-llc:main Sep 4, 2023
132 of 133 checks passed
@NiteshK84 NiteshK84 deleted the unique_consecutive branch September 4, 2023 17:15
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unique_consecutive
3 participants