Update: compile updated to trace in ivy repo #22854

HaiderSultanArc · 2023-08-31T16:16:29Z

We are updating our ivy.compile( ) function to ivy.trace( ) function.
This requires updating the Docs, Ivy Repo, Graph Compiler Repo, Demos, and other places to refer to Tracer rather than Graph Compiler!

This PR updates Ivy Repo Code!

github-actions · 2023-08-31T16:18:00Z

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

mattbarrett98

I presume a lot of tests are failing due to what I pointed out, though I can't seem to confirm this with the CI (it just seems to show a long list of what's failing without the error messages).

Also I think you missed this https://github.com/unifyai/ivy/blob/main/ivy/__init__.py#L791 - presume this try will fail also when trying to import compile which is now trace

ivy/compiler/compiler.py

HaiderSultanArc · 2023-09-01T14:21:49Z

I presume a lot of tests are failing due to what I pointed out, though I can't seem to confirm this with the CI (it just seems to show a long list of what's failing without the error messages).

Also I think you missed this https://github.com/unifyai/ivy/blob/main/ivy/__init__.py#L791 - presume this try will fail also when trying to import compile which is now trace

Yeah I missed that 😅. Thanks for pointing out!

guillesanbri · 2023-09-01T17:25:19Z

heads up before leaving a review, all the module stuff is being refactored at the moment afaik, so it will most likely become a nightmare to merge the changes 😅 I'd say better to wait to change this if the module refactor is going to be merged soon (which I assume it is)

HaiderSultanArc · 2023-09-01T19:55:03Z

heads up before leaving a review, all the module stuff is being refactored at the moment afaik, so it will most likely become a nightmare to merge the changes 😅 I'd say better to wait to change this if the module refactor is going to be merged soon (which I assume it is)

Yeah, I'll wait for it @guillesanbri 😄.

guillesanbri · 2023-09-22T08:41:29Z

ivy/compiler/compiler.py

-        from ._compiler_38 import compile as _compile
+        from ._compiler_38 import trace as _trace
    else:
-        from ._compiler import compile as _compile
+        from ._compiler import trace as _trace


small heads up: this will need to be changed to from ._compiler import compile as _trace as the .so won't be updated yet

…nArc/ivy into compile_to_trace_ivy

guillesanbri · 2023-09-26T15:48:01Z

ivy/__init__.py

@@ -812,7 +812,7 @@ class Node(str):
 except:
    pass
 try:
-    from .compiler.compiler import transpile, compile, unify
+    from .compiler.compiler import transpile, trace, unify


trace_graph here

Oh, I searched for trace( LOL. Obviously it would get missed. Sorry for that 😅

guillesanbri · 2023-09-26T15:49:27Z

ivy/utils/_importlib.py

-        spec.loader.exec_module(module, ivy._compiled_id)
+        spec.loader.exec_module(
+            module, ivy._compiled_id
+        )  # ! Not sure about what this ID is


I don't think this is related we can remove the comment

guillesanbri · 2023-09-26T15:50:29Z

ivy/utils/exceptions.py

@@ -28,22 +28,22 @@ def _remove_so_log(trace):
        if ".pyx" in repr(st):
            continue
        if "<string>" in repr(st):
-            if "compiled_fn" in repr(st) and module_frame:
+            if "traced_fn" in repr(st) and module_frame:


this probably needs to be compiled_fn until the changes are effective in the .so file

yeah makes sense!

guillesanbri · 2023-09-26T15:51:31Z

ivy/utils/exceptions.py


        if "<module>" in repr(st):
            module_frame = old_frames[idx]
            module_st = st
        elif (
            transpile_frame is None
            and os.path.join("ivy", "compiler") in st.filename
-            and st.name in ["compile", "transpile"]
+            and st.name in ["trace", "transpile"]


not entirely sure about this one, so just highlighting in case it also needs to be updated only once the .so file is updated

yeah, it's comming from .so file so it would be compile for now

Update: compile updated to trace in ivy repo

5d749d7

HaiderSultanArc added Next Release This issue or PR should only be considered once the next release is out. Tracer Anything related to tracing labels Aug 31, 2023

HaiderSultanArc self-assigned this Aug 31, 2023

HaiderSultanArc requested a review from CatB1t as a code owner August 31, 2023 16:16

HaiderSultanArc linked an issue Aug 31, 2023 that may be closed by this pull request

Ivy Repo #22855

Closed

HaiderSultanArc requested review from guillesanbri and mattbarrett98 August 31, 2023 16:17

mattbarrett98 reviewed Sep 1, 2023

View reviewed changes

ivy/compiler/compiler.py Outdated Show resolved Hide resolved

HaiderSultanArc added 3 commits September 1, 2023 19:25

Merge branch 'main' into compile_to_trace_ivy

92422f4

fix: format fix

a92c9a8

Update: Compile to Trace update in __init__.py

97fa1eb

HaiderSultanArc added 6 commits September 6, 2023 16:41

Merge branch 'main' into compile_to_trace_ivy

df857b1

Merge branch 'unifyai:main' into compile_to_trace_ivy

d0e670b

Merge branch 'unifyai:main' into compile_to_trace_ivy

aff77d3

fix: skip-compile-testing to skip-trace-testing

43f9bdc

update: BuiltTraceStrategy

ca0a7a0

Merge branch 'main' into compile_to_trace_ivy

e0abd7c

HaiderSultanArc requested a review from sherry30 as a code owner September 18, 2023 11:32

HaiderSultanArc requested a review from mattbarrett98 September 18, 2023 11:32

guillesanbri suggested changes Sep 22, 2023

View reviewed changes

HaiderSultanArc added 5 commits September 22, 2023 10:28

Merge main

a337c33

Merge main

0983534

Merge branch 'unifyai:main' into compile_to_trace_ivy

b1888c6

Update: compile -> trace in

306e9fa

Merge branch 'compile_to_trace_ivy' of https://github.com/HaiderSulta…

62d5b95

…nArc/ivy into compile_to_trace_ivy

HaiderSultanArc added 5 commits September 22, 2023 13:04

fix: test_compile attrib

43bf927

Update: some missing instances of compile

91c7de0

Update: some instances in comments

4d95937

Merge branch 'unifyai:main' into compile_to_trace_ivy

a4fd5ee

Merge branch 'compile_to_trace_ivy' of https://github.com/HaiderSulta…

c18e192

…nArc/ivy into compile_to_trace_ivy

HaiderSultanArc requested review from Aarsh2001 and fnhirwa as code owners September 22, 2023 16:24

revert: weird submodule issue

cc7e2bc

HaiderSultanArc force-pushed the compile_to_trace_ivy branch from cb90313 to cc7e2bc Compare September 22, 2023 16:33

HaiderSultanArc added 3 commits September 22, 2023 16:39

Fixed?

472b5f7

Merge branch 'main' into compile_to_trace_ivy

943ff69

Merge branch 'unifyai:main' into compile_to_trace_ivy

68e6139

HaiderSultanArc requested a review from guillesanbri September 25, 2023 09:44

Merge branch 'main' into compile_to_trace_ivy

0aed55f

HaiderSultanArc requested a review from KareemMAX as a code owner September 26, 2023 14:54

HaiderSultanArc added 3 commits September 26, 2023 15:03

update: trace -> trace_graph

3245a53

Update Submodule

e1a2f55

Merge branch 'unifyai:main' into compile_to_trace_ivy

3852c8e

guillesanbri suggested changes Sep 26, 2023

View reviewed changes

HaiderSultanArc added 2 commits September 26, 2023 16:14

Update: minor change

1bbde84

Update: minor change

4a939ef

HaiderSultanArc merged commit ae85941 into ivy-llc:main Sep 26, 2023
50 of 137 checks passed

iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023

Update: compile updated to trace in ivy repo (ivy-llc#22854)

d55a31e

HaiderSultanArc deleted the compile_to_trace_ivy branch October 1, 2023 17:15

druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023

Update: compile updated to trace in ivy repo (ivy-llc#22854)

c592131

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update: compile updated to trace in ivy repo #22854

Update: compile updated to trace in ivy repo #22854

HaiderSultanArc commented Aug 31, 2023 •

edited

Loading

github-actions bot commented Aug 31, 2023

mattbarrett98 left a comment

HaiderSultanArc commented Sep 1, 2023

guillesanbri commented Sep 1, 2023

HaiderSultanArc commented Sep 1, 2023

guillesanbri Sep 22, 2023

HaiderSultanArc Sep 22, 2023

guillesanbri Sep 26, 2023

HaiderSultanArc Sep 26, 2023

guillesanbri Sep 26, 2023

HaiderSultanArc Sep 26, 2023

guillesanbri Sep 26, 2023

HaiderSultanArc Sep 26, 2023

guillesanbri Sep 26, 2023

HaiderSultanArc Sep 26, 2023

Update: compile updated to trace in ivy repo #22854

Update: compile updated to trace in ivy repo #22854

Conversation

HaiderSultanArc commented Aug 31, 2023 • edited Loading

github-actions bot commented Aug 31, 2023

mattbarrett98 left a comment

Choose a reason for hiding this comment

HaiderSultanArc commented Sep 1, 2023

guillesanbri commented Sep 1, 2023

HaiderSultanArc commented Sep 1, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

HaiderSultanArc commented Aug 31, 2023 •

edited

Loading