Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added numpy frontend eigvals function and its test #22920

Merged
merged 12 commits into from
Sep 11, 2023
Merged

Added numpy frontend eigvals function and its test #22920

merged 12 commits into from
Sep 11, 2023

Conversation

Javeria-Siddique
Copy link
Contributor

@Javeria-Siddique Javeria-Siddique commented Sep 1, 2023 •
edited
Loading

Close #22302

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Sep 1, 2023
fnhirwa
fnhirwa suggested changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Javeria-Siddique

Thanks for the PR😊
Would you remove the changes that you added in the files from .idea directory, the rest looks good to me🙂
Thanks

@Javeria-Siddique
Copy link
Contributor Author

Javeria-Siddique commented Sep 6, 2023 •
edited
Loading

Thanks for reviewing the PR @hirwa-nshuti

I have fixed the files. Can you re-review it?

fnhirwa
fnhirwa approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Javeria-Siddique

Thanks for contributing😊
All looks great, going to merge!

@fnhirwa fnhirwa merged commit b6cdb1f into ivy-llc:main Sep 11, 2023
263 of 265 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
@Javeria-Siddique @fnhirwa @iababio
feat(Numpy-frontend): Added eigvals function to numpy frontend (ivy-l…
befce7d 
…lc#22920)

Co-authored-by: hirwa-nshuti <[email protected]>
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
@Javeria-Siddique @fnhirwa @druvdub
feat(Numpy-frontend): Added eigvals function to numpy frontend (ivy-l…
262eaa5 
…lc#22920)

Co-authored-by: hirwa-nshuti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa approved these changes

@Aarsh2001 Aarsh2001 Awaiting requested review from Aarsh2001

@zaeemansari70 zaeemansari70 Awaiting requested review from zaeemansari70

Assignees

@fnhirwa fnhirwa

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eigvals
3 participants
@Javeria-Siddique @fnhirwa @ivy-leaves