Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lu_solve to PyTorch Frontend #22922

Closed
wants to merge 6 commits into from

Conversation

NoahWaltman
Copy link

@NoahWaltman NoahWaltman commented Sep 1, 2023

PR Description

Related Issue

lu_solve #22754

Close #22754

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 1, 2023
@a0m0rajab
Copy link
Contributor

Hi thanks for the PR, can you implement the tests of the function?

@NoahWaltman
Copy link
Author

@a0m0rajab Hi! Could you take a look at the new commit where I implemented the test function?

@a0m0rajab
Copy link
Contributor

Thanks, we can wait Rick to check this. Meanwhile, could you check the lint issue? I think the docs is explaining how to do it.

@NoahWaltman
Copy link
Author

NoahWaltman commented Sep 3, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

@NoahWaltman
Copy link
Author

@RickSanchezStoic

@RickSanchezStoic
Copy link
Contributor

Hi @NoahWaltman can you see the intelligent-tests-pr / run_tests (1) (pull_request) logs and try fixing the errors.

@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

Copy link
Contributor

@he11owthere he11owthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there! Nice work but tests on CI are still failing for all the backends:
https://github.com/unifyai/ivy/actions/runs/7344883998/job/19997453454?pr=22922#step:6:15

@ivy-seed ivy-seed closed this Feb 16, 2024
@ivy-seed
Copy link

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lu_solve
6 participants