Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added digamma in paddle frontend #22959

Merged
merged 28 commits into from
Sep 4, 2023
Merged

Conversation

AbdullahSabry
Copy link
Contributor

Closes #22941

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 2, 2023
@AbdullahSabry
Copy link
Contributor Author

Hey @abdulasiraj

Ran into an issue in the paddle backend to needed to reference the function ivy.digamma this way in order to avoid the issue. Review this PR and let me know if everything is good. Thanks!

Copy link
Contributor

@abdulasiraj abdulasiraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abdulasiraj abdulasiraj merged commit efaf691 into ivy-llc:main Sep 4, 2023
114 of 133 checks passed
@AbdullahSabry AbdullahSabry deleted the digamma_paddle branch September 11, 2023 01:31
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digamma
3 participants