-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added inplace Remainder in paddle frontend #22962
Conversation
Thanks for contributing to Ivy! 😊👏 |
@hello-fri-end Please review the PR. It passing all the test on my side. |
@hello-fri-end waiting for review. |
@hello-fri-end could you please take a look at PR? it's been 1 week now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArsalanAli915, thanks for working on this issue and apologies for the delayed response. Just a few minor comments and we are good to merge:
- You should only add
paddle.remainder_
function as part of this PR.. - The corresponding test should be implemented in
ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_paddle_math.py
.
Please make the required changes and re-request a review. Happy to clarify any doubts :)
@hello-fri-end Thanks for providing the kind review in the PR. As for the path ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_paddle_math.py is concerned, I think it is changed now as ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py because I can find it in the repo. Please do let know if I can do anything else. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArsalanAli915. You are right, the file seems to be renamed to ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py
. Let's resolve the comments from the previous review then. Happy to review again once you are done. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
@hello-fri-end Thanks for helping me with a double check. I have resolved previous reviews. But still, if u think there is something missing please let me know. I am always there to act. thanks. |
@hello-fri-end Also I have tried to resolve lint in CI but It is passing on locally but IDK why it's not passing on CI. I think this is something related to the main repo. thansk. |
ivy-gardener |
ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArsalanAli915 , as mentioned last time, could you please undo all the unrelated changes from ivy_tests/test_ivy/test_frontends/test_paddle/test_tensor/test_math.py
? You should only add the test for the in-place remainder function and not modify anything else. Happy to review once again after you have resoved this.
@hello-fri-end Thank you very much for giving my PR so much consideration. I really appreciate it. Actully due to change in files again bu ivy I have created new PR. where every thing ready to merge. This is the link of PR #25779 solved this issue. Please do look and let me know anything needed to be changed. thanks. |
Looks like it has already been merged. Thanks for the contribution 🥳 |
Close #22961
PR Description
Related Issue
Close #
Checklist
Socials: