Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fftfreq() paddle frontend function in paddle.fft #22968

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

p1utoze
Copy link
Contributor

@p1utoze p1utoze commented Sep 3, 2023

PR Description

Add fftfreq() Paddle frontend function in paddle.fft

Related Issue

Resolves: #22948

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 3, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@p1utoze
Copy link
Contributor Author

p1utoze commented Sep 4, 2023

@D0m-inic Hi! Currently I have implemented fftfreq() function in paddle frontend but it haven't yet been implemented in the functional API. I have raised a suggestion issue #22992 for it. How should I proceed with this PR?

@p1utoze
Copy link
Contributor Author

p1utoze commented Sep 14, 2023

@D0m-inic Hi! All my test cases are passing. Can you review the code and merge it?

@ivy-seed ivy-seed assigned KareemMAX and unassigned D0m-inic Sep 17, 2023
@p1utoze
Copy link
Contributor Author

p1utoze commented Sep 19, 2023

@KareemMAX Hey there! Can you review my PR? I have implemented the function and all the test cases are passing.

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @p1utoze,
Great work 🚀, just a small comment that I want you to address then we are good to run the final tests and merge

if d * n == 0:
raise ValueError("d or n should not be 0.")

dtype = ivy.default_dtype()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to check if it None or not before doing that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sorry for the late response. I have added the dtype check.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@p1utoze p1utoze changed the title Added fftfreq() paddle frontend function in paddle.fft feat: add fftfreq() paddle frontend function in paddle.fft Sep 27, 2023
Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KareemMAX KareemMAX merged commit 85247b8 into ivy-llc:main Sep 28, 2023
106 of 145 checks passed
@p1utoze p1utoze deleted the paddle-fftfreq branch September 29, 2023 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fftfreq
4 participants