Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): Add torch.complex, torch.polar and its tests #22979

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

dettmerramon
Copy link
Contributor

@dettmerramon dettmerramon commented Sep 3, 2023

PR Description

Adds torch.polar and torch.complex to the torch frontend (see creation_ops issue #8), alongside its tests.
Ended up implementing torch.complex since it made more sense to be able to use it for torch.polar.

I've made some comments on the PR to make some of my decisions more clear, you can probably see them while going through the code or in the PR feed below.

Related Issue

Closes #22752 and #22978

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 3, 2023
@dettmerramon dettmerramon changed the title feat(frontend): add torch.complex and torch.polar and its tests Add torch.complex, torch.polar and its tests Sep 3, 2023
Copy link
Contributor

@sherry30 sherry30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested a few changes

ivy/functional/frontends/torch/creation_ops.py Outdated Show resolved Hide resolved
ivy/functional/frontends/torch/creation_ops.py Outdated Show resolved Hide resolved
ivy/functional/frontends/torch/creation_ops.py Outdated Show resolved Hide resolved
@dettmerramon dettmerramon force-pushed the ivy-torch-frontend-polar branch from 04a57ee to 13113f2 Compare September 9, 2023 15:26
@sherry30 sherry30 requested a review from AnnaTz September 11, 2023 16:08
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@dettmerramon dettmerramon changed the title Add torch.complex, torch.polar and its tests feat(frontend): Add torch.complex, torch.polar and its tests Sep 15, 2023
@dettmerramon dettmerramon requested a review from AnnaTz September 15, 2023 02:11
@AnnaTz AnnaTz merged commit fd2241e into ivy-llc:main Sep 18, 2023
265 of 269 checks passed
iababio pushed a commit to iababio/ivy that referenced this pull request Sep 27, 2023
druvdub pushed a commit to druvdub/ivy that referenced this pull request Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polar
4 participants