-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): Add torch.complex, torch.polar and its tests #22979
Conversation
Thanks for contributing to Ivy! 😊👏 |
ivy_tests/test_ivy/test_frontends/test_torch/test_creation_ops.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requested a few changes
ivy_tests/test_ivy/test_frontends/test_torch/test_creation_ops.py
Outdated
Show resolved
Hide resolved
04a57ee
to
13113f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
PR Description
Adds
torch.polar
andtorch.complex
to the torch frontend (seecreation_ops
issue #8), alongside its tests.Ended up implementing
torch.complex
since it made more sense to be able to use it fortorch.polar
.I've made some comments on the PR to make some of my decisions more clear, you can probably see them while going through the code or in the PR feed below.
Related Issue
Closes #22752 and #22978
Checklist