-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add fromiter to numpy frontend #22984
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, your tests are currently all failing for the same error:
E TypeError: fromiter() got an unexpected keyword argument 'iterable'
Please read the comments below
ivy_tests/test_ivy/test_frontends/test_numpy/test_creation_routines/test_from_shape_or_value.py
Show resolved
Hide resolved
ivy_tests/test_ivy/test_frontends/test_numpy/test_creation_routines/test_from_shape_or_value.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your test by using helpers.dtype_and_values to generate the iter argument as your current method will cause the following error when it generate a massive value:
E OverflowError: Python int too large to convert to C long
Read this(https://unify.ai/docs/ivy/overview/deep_dive/ivy_frontends_tests.html) for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Protected Branch
In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to copy the changes you have made to a new branch in your repo as it is not a good practice to merge from your main to ivy main. In addition, there are some major changes applied to the code base recently, so take this as a chance to update your repo as well. Thanks.
Thank you for this PR, here is the CI results: This pull request does not result in any additional test failures. Congratulations! |
PR Description
Related Issue
Close #22814
Checklist
Socials: