Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paddlecreation2 #23049

Closed
wants to merge 54 commits into from
Closed

Paddlecreation2 #23049

wants to merge 54 commits into from

Conversation

Novendobi
Copy link

@Novendobi Novendobi commented Sep 4, 2023

PR random uniform

Related Issue paddle.tensor creation

Close #-[] 22965

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 4, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@umairjavaid
Copy link
Contributor

Make sure the tests are passing, once you have fixed the supported dtype decorator. I'll be happy to re-review it =)

@Novendobi
Copy link
Author

Make sure the tests are passing, once you have fixed the supported dtype decorator. I'll be happy to re-review it =)

I have put the correct dtype syncing with its version

Copy link
Contributor

@umairjavaid umairjavaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are not passing. You need to pass stratergies for the low and high positional arguments

E   TypeError: random_uniform() missing 2 required positional arguments: 'low' and 'high'
E   Falsifying example: test_paddle_random_uniform(
E       on_device='cpu',
E       backend_fw='jax',
E       frontend='paddle',
E       dtype_and_shape=(['int64'], [array(0)], ()),
E       test_flags=FrontendFunctionTestFlags(
E           num_positional_args=0,
E           with_out=False,
E           inplace=False,
E           as_variable=[False],
E           native_arrays=[False],
E           test_compile=False,
E           generate_frontend_arrays=False,
E           transpile=False,
E           precision_mode=False,
E       ),
E       fn_tree='ivy.functional.frontends.paddle.random_uniform',
E   )
E   
E   You can reproduce this example by temporarily adding @reproduce_failure('6.84.1', b'AXicY2DAAAAAEwAB') as a decorator on your test case

@Novendobi Novendobi closed this Sep 8, 2023
@Novendobi Novendobi deleted the paddlecreation2 branch September 8, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants