Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added paddle frontend for binary cross entropy #23093

Closed
wants to merge 1 commit into from
Closed

Added paddle frontend for binary cross entropy #23093

wants to merge 1 commit into from

Conversation

Kiprop2020
Copy link
Contributor

@Kiprop2020 Kiprop2020 commented Sep 5, 2023

PR Description

Related Issue

Close #22215

Checklist

  • Added a function "binary_cross_entropy"
  • Added test function "test_paddle_binary_cross_entropy"
  • Followed all steps provided

The tests encountered an issue "Frontend function returned non-frontend arrays: ivy.array([float, float])". I think this happens because the ground-truth function returns a paddle.Tensor object while this function returns an ivy.frontends.paddle.Tensor object. In converting the ivy array to a paddle tensor I used ivy.functional.frontends.paddle.to_tensor() which does not return the same data type as paddle.to_tensor().

Socials:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 5, 2023
@ivy-leaves
Copy link

If you are working on an open task, please edit the PR description to link to the issue you've created.

For more information, please check ToDo List Issues Guide.

Thank you 🤗

@Kiprop2020 Kiprop2020 marked this pull request as ready for review September 5, 2023 21:34
@Kiprop2020 Kiprop2020 closed this by deleting the head repository Sep 9, 2023
@arshPratap
Copy link
Contributor

Hi @Kiprop2020 ..I have currently submitted a PR #22216 for this issue .. which I had raised earlier and if its alright with you , I would like to continue my work on this issue .
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

binary_cross_entropy
4 participants