Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argpartition #23095

Closed
wants to merge 4 commits into from
Closed

Argpartition #23095

wants to merge 4 commits into from

Conversation

joeadham
Copy link

@joeadham joeadham commented Sep 5, 2023

PR Description

Implemented the argpartition functions in the backend experimental

Related Issue

Close #22202

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

Twitter

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added PaddlePaddle Backend Developing the Paddle Paddle Backend. Ivy Functional API Ivy API Experimental Run CI for testing API experimental/New feature or request labels Sep 5, 2023
@KareemMAX
Copy link
Contributor

KareemMAX commented Sep 5, 2023

ivy-gardener
✅ Ivy gardener has formatted your code.
If changes are requested, don't forget to pull your fork.

Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @joeadham

Thanks for contributing to Ivy😊
First of all, you don't have to push the changes to .idea files along with your PR files, so you'll have to remove them.

Also using topk function is innefficient depending on the superset behaviour of the function you can take a reference to the same implemented numpy function https://numpy.org/doc/stable/reference/generated/numpy.argpartition.html to understand the use of the function, then continue with your implementation.

Thanks, and happy coding 🤞

@ivy-seed
Copy link

ivy-seed commented Feb 8, 2024

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@ivy-seed ivy-seed added the Stale label Feb 8, 2024
@ivy-seed ivy-seed closed this Feb 27, 2024
@ivy-seed
Copy link

This PR has been closed because it has been marked as stale for more than 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Ivy Functional API PaddlePaddle Backend Developing the Paddle Paddle Backend. Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argpartition
6 participants