-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Argpartition #23095
Argpartition #23095
Conversation
Thanks for contributing to Ivy! 😊👏 |
ivy-gardener |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @joeadham
Thanks for contributing to Ivy😊
First of all, you don't have to push the changes to .idea
files along with your PR files, so you'll have to remove them.
Also using topk
function is innefficient depending on the superset behaviour of the function you can take a reference to the same implemented numpy function https://numpy.org/doc/stable/reference/generated/numpy.argpartition.html to understand the use of the function, then continue with your implementation.
Thanks, and happy coding 🤞
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
PR Description
Implemented the argpartition functions in the backend experimental
Related Issue
Close #22202
Checklist
Socials:
Twitter