Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jax-backend): set symmetrize_input=False in jax.eigh for consistency #23100

Closed
wants to merge 1 commit into from

Conversation

akshatvishu
Copy link
Contributor

Set the symmetrize_input argument to False in jax.eigh to ensure consistent behavior with other backends. The default behavior in jax was leading to different eigenvalues than other frameworks.

Related Issue

Close #23098

Set the symmetrize_input argument to False in jax.eigh to ensure consistent behavior with other backends.
The default behavior in jax was leading to different eigenvalues than other frameworks.
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

Copy link
Contributor

@KareemMAX KareemMAX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akshatvishu,
Your code looks sensible to me, but I guess we have a more systematic issue here. In the main branch the failing tests for this function are torch and numpy, not jax. That mean we both have a bug in those backends as well as a potential bug on the test (according to #23098).

Can you fix those issues and make sure eigh passes everything before we proceed? Otherwise I feel we would be digging our own hole to fall in

@KareemMAX
Copy link
Contributor

KareemMAX commented Sep 6, 2023

Also, I found out that the test is quite non-standard (and a bit old). ref

You might want to ask for @sherry30's opinion. Or maybe reach out to our #testing channel on discord.

@ivy-seed ivy-seed added the Stale label Oct 9, 2023
@ivy-seed
Copy link

ivy-seed commented Oct 9, 2023

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants