-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nested maps on torch.compile for torch tensors #23108
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Killua7362, thanks for diving into this! I think if this fixes the issue, we can just refactor the include_derived
argument to simply be a Dict[str, bool]
at all places. So I'd suggest refactoring this function further along with all it's usages in the framework to instead pass a "tuple"
instead of a tuple
, "list"
instead of list
and so on 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Let's wait for the CI to complete running tests as it's quite a fundamental function, thanks @Killua7362 😄
Thank you Ved, let's hope nothing breaks XD |
If you are working on an open task, please edit the PR description to link to the issue you've created. For more information, please check ToDo List Issues Guide. Thank you 🤗 |
torch.compile does not work well with dictionary of types. So changed types to str(types).