-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add count_nonzero to paddle/tensor/math with associated tests #23426
Conversation
Thanks for contributing to Ivy! 😊👏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should check your commited changes as it included some not relevent changes that should not be included. like docs and deep_dive stuffs
Could you help me out with the specific docs? I merged my working branch with the main branch and it seems they came with the merge. What about the count-nonzero function implementation? @Daniel4078 |
My advice is to copy your new code somewhere first, then create a new branch in your repo from the current master branch so that all the other files are up to date, then you can copy back your code and push them in one commit (it will be on a new PR due to the new branch). |
Hello, @maxxies , @Daniel4078 , Just wanted to let you know that this issue was already opened by me last week and I have also already opened a PR for it. Can you please close this one ? @Daniel4078 you can review the PR #23282 please ? |
@AryanSharma21 Done, but I suppose the people assigned to your PR should be merging it in most cases |
PR Description
The mathematical count_nonzero function was added to the Paddle Frontend.
Related Issue
Close #23118
Checklist
Socials:
https://twitter.com/maxwell_mawube