Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count_nonzero to paddle/tensor/math with associated tests #23426

Closed
wants to merge 4 commits into from

Conversation

maxxies
Copy link
Contributor

@maxxies maxxies commented Sep 11, 2023

PR Description

The mathematical count_nonzero function was added to the Paddle Frontend.

Related Issue

Close #23118

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you follow the steps we provided?

Socials:

https://twitter.com/maxwell_mawube

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Sep 11, 2023
@ivy-leaves ivy-leaves added the PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist label Sep 11, 2023
Copy link
Contributor

@Daniel4078 Daniel4078 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check your commited changes as it included some not relevent changes that should not be included. like docs and deep_dive stuffs

@maxxies
Copy link
Contributor Author

maxxies commented Sep 12, 2023

Could you help me out with the specific docs? I merged my working branch with the main branch and it seems they came with the merge. What about the count-nonzero function implementation? @Daniel4078

@Daniel4078
Copy link
Contributor

Daniel4078 commented Sep 12, 2023

Could you help me out with the specific docs? I merged my working branch with the main branch and it seems they came with the merge. What about the count-nonzero function implementation? @Daniel4078

My advice is to copy your new code somewhere first, then create a new branch in your repo from the current master branch so that all the other files are up to date, then you can copy back your code and push them in one commit (it will be on a new PR due to the new branch).

@AryanSharma21
Copy link
Contributor

Hello, @maxxies , @Daniel4078 , Just wanted to let you know that this issue was already opened by me last week and I have also already opened a PR for it. Can you please close this one ?

@Daniel4078 you can review the PR #23282 please ?

@Daniel4078 Daniel4078 closed this Sep 12, 2023
@Daniel4078
Copy link
Contributor

Hello, @maxxies , @Daniel4078 , Just wanted to let you know that this issue was already opened by me last week and I have also already opened a PR for it. Can you please close this one ?

@Daniel4078 you can review the PR #23282 please ?

@AryanSharma21 Done, but I suppose the people assigned to your PR should be merging it in most cases

@maxxies maxxies deleted the feature/paddle_countnonzero branch September 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist PyTorch Frontend Developing the PyTorch Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count_nonzero
4 participants