feat: implement rfftn to Paddle Frontend (#23484) #23537
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ivy-leaves
added
the
Paddle Frontend
Kilvny
changed the title
|
Why these 2 check are failing, can you help me with that? |
Kilvny
changed the title
Done @KareemMAX |
| s = x.shape | ||
|
|
||
| # Apply rfft along the last axis | ||
| rfft_result = ivy.rfftn(x, s=s, axes=axes, norm=norm, name=name) |
There was a problem hiding this comment.
TypeError: rfftn() got an unexpected keyword argument 'name'. This line is throwing an error. there is no name
parameter in rfftn please remove it and add out=name
There was a problem hiding this comment.
Thank you, the change is done,
FYA
KareemMAX
requested review from
KareemMAX
and removed request for
KareemMAX and
Mr-Niraj-Kulkarni
There was a problem hiding this comment.
Hi @Kilvny
Apologies for the delay in review. Have been a little swamped with work recently and so havent had the time to review any PRs 😅
With regards to the PR itself, the implementation does look good overall. However, I am noticing that the CI tests are failing here with the following error:
E ivy.utils.exceptions.IvyBackendException: tensorflow: rfftn: Invalid FFT input: `x` must be of a real dtype. Received: <dtype: 'complex128'>Could you kindly fix the merge conflicts and look into fixing the above issue? Fee free to re-request a review once that's done? Thanks!😄
|
Hi @YushaArif99 Thank you so much for the reply, anyways, I resolved the conflicts, but regarding the checks that fails, I need some help and guidance I don't know exactly what causes the tests to fail, your help is highly appreciated |
|
This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days. |
|
This PR has been closed because it has been marked as stale for more than 7 days with no activity. |
PR Description
added rfftn to Paddle Frontend and added tests related to it
Related Issue
(#23484)
Close #23484
Checklist
Socials: