refactor: Refactored test_assertions.py file.
#23584
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Sai-Suraj-27
changed the title
test_assertions.py file.test_assertions.py file.
|
@Sai-Suraj-27, Can you please tag the issue for which these changes were required to be made. Thanks |
Sir, I made these on my own to make the code better and clean. This is a refactoring PR. It's not related to any issue. |
There was a problem hiding this comment.
Hey @Sai-Suraj-27, just requested a minor change, rest looks good to merge, thanks 😄(thanks for requesting the review @Mr-Niraj-Kulkarni)
| sys.stdout = orig_stdout | ||
| f.close() | ||
|
|
||
| with open(filename, "w") as f: |
There was a problem hiding this comment.
let's add a new line before and after this block similar to how it's done with the next blocks in this function. Same applies to the other changes made
There was a problem hiding this comment.
@vedpatwardhan sir, I made the suggested changes, Please look into it now, Thank you.
There was a problem hiding this comment.
lgtm! Feel free to merge the PR @Mr-Niraj-Kulkarni, thanks @Sai-Suraj-27 😄
PR Description
Refactored
test_assertions.pyfile. Usedwithwhen opening files to ensure closure, as opening files in this way is more concise, and also ensures that the call tofile.close()is not skipped if there is an exception. Also, removed unnecessary calls to.keys()when iterating over a dictionary as the default behaviour when iterating over a dictionary is to iterate over the keys.Checklist
Socials: